Project

General

Profile

Actions

Bug #11704

closed

Configuration no report appears as "green" icon

Added by Ohad Levy over 8 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Reporting
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

After upgrading to the global host status, hosts who has no puppet report appear as green vs warning.
see attachment.


Files


Related issues 3 (0 open3 closed)

Related to Foreman - Feature #10782: Add global status for hostsClosedMarek Hulán06/11/2015Actions
Related to Foreman - Bug #11791: N+1 query on hosts#index retrieving puppet_proxyClosedMarek Hulán09/14/2015Actions
Related to Foreman - Refactor #11836: Rename Puppet settings to ConfigurationClosedActions
Actions #1

Updated by Ohad Levy over 8 years ago

Actions #2

Updated by Dominic Cleal over 8 years ago

  • Category set to Reporting
  • translation missing: en.field_release set to 63

I think the intention is not to put hosts into a warning state when perhaps they don't even use configuration management.

However, we could implement #relevant? on ConfigurationStatus to be true when puppet? is true (and let other config management plugins to add their own conditions), then set it to warning if there are no reports.

Actions #3

Updated by Marek Hulán over 8 years ago

So we should probably distinguish between a host with puppet master and the rest, or is there better way to resolve "#puppet?". Otherwise we'd mark discovered hosts or hosts not using puppet with warning flag.

Actions #4

Updated by Dominic Cleal over 8 years ago

I think checking puppet_proxy (sorry, not #puppet?) is the only thing we usually do, e.g. on the host#edit form for whether to show Puppet-related tabs. Host status shouldn't apply to discovered hosts, but I think it's worth distinguishing between a host that should be sending reports and one that shouldn't.

Actions #5

Updated by Marek Hulán over 8 years ago

  • Assignee set to Marek Hulán

OK, that makes sense to me and you're right about discovered hosts. I'll probably get to it this week.

Actions #6

Updated by The Foreman Bot over 8 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2705 added
  • Pull request deleted ()
Actions #7

Updated by Marek Hulán over 8 years ago

  • % Done changed from 0 to 100
  • Status changed from Ready For Testing to Closed
Actions #8

Updated by Dominic Cleal over 8 years ago

  • Related to Bug #11791: N+1 query on hosts#index retrieving puppet_proxy added
Actions #9

Updated by Marek Hulán over 8 years ago

  • Related to Refactor #11836: Rename Puppet settings to Configuration added
Actions

Also available in: Atom PDF