Project

General

Profile

Actions

Bug #11350

closed

Duplicate parameters can be created within subtype

Added by Daniel Lobato Garcia over 8 years ago. Updated over 8 years ago.

Status:
Rejected
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

The Parameter class leaves its :name uniqueness validation to subtypes such as CommonParameter, GroupParameter, and so forth. This means that one can trivially create duplicate parameters by calling Parameter.new, then changing the type attribute of the newly created object. To avoid this situation (and save some duplicated code) we can simply declare a default validation on all Parameter names scoped by reference_id, and override it for CommonParameter which doesn't have a reference_id.

Actions #1

Updated by The Foreman Bot over 8 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2604 added
  • Pull request deleted ()
Actions #2

Updated by Daniel Lobato Garcia over 8 years ago

  • Status changed from Ready For Testing to Rejected
Actions

Also available in: Atom PDF