Project

General

Profile

Actions

Bug #14854

closed

Libvirt connection leaks

Added by Thomas McKay about 8 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Category:
Compute resources - libvirt
Target version:
-
Difficulty:
Triaged:
Yes
Fixed in Releases:
Found in Releases:

Description

After a morning of provisioning VMs on libvirt where the VMs failed to install packages (could not fetch glibc-common rpm so anaconda failed to finish), the libvirt compute resource became unreachable with the message in UI of

Call to virConnectOpen failed: End of file while reading data: Ncat: Connection reset by peer.: Input/output error

/var/log/messages on the libvirt host indicated

libvirtd[26937]: Too many active clients (20), dropping connection from 127.0.0.1;0

Restarting the rails server freed up the connections and the compute resource was usable again.

It appears that libvirt connections are being held onto by the server.


Related issues 2 (1 open1 closed)

Related to Smart Proxy - Bug #14880: Libvirt connection leaksRejectedLukas ZapletalActions
Related to Foreman - Bug #6405: Failure to reconnect on libvirtd restartNewActions
Actions #1

Updated by Thomas McKay about 8 years ago

I used this command to watch the connection count during debug

sudo netstat -anp | grep libvirt | wc -l
Actions #2

Updated by Thomas McKay about 8 years ago

A note on setup. This is katello running in a VM on laptop's libvirt. The compute resource is: qemu+ssh:/system

Actions #3

Updated by Lukas Zapletal about 8 years ago

Thanks Tom, good observation. It looks like the behavior is same for local sockets. And the same problem is for foreman proxy libvirt provider. I will add new ticket and fix that first, then I will take look on this one.

Actions #4

Updated by Lukas Zapletal about 8 years ago

  • Subject changed from libvirt connections not closed - Call to virConnectOpen failed: End of file while reading data: Ncat: Connection reset by peer.: Input/output error to Libvirt connection leaks

I think the best way to handle this is to create SimpleConnectionManager that will provide a block opening and closing connection automatically. Then we need to rewrite all our code to blocks.

This opens up doors for implementing PooledConnectionManager (e.g. via https://github.com/mperham/connection_pool gem) later on, so we can re-use connections. The gem assumes self-healing connections which is not the case for libvirt, so the manager need to implement "ping" check before every call and heal the broken connections. For libvirt this can be implemented via fog with the "get_node_info" call which raises

Libvirt::RetrieveError: Call to virNodeGetInfo failed: internal error: client socket is closed

on broken connections.

Actions #5

Updated by Lukas Zapletal about 8 years ago

  • Related to Bug #14880: Libvirt connection leaks added
Actions #6

Updated by Lukas Zapletal over 5 years ago

  • Related to Bug #6405: Failure to reconnect on libvirtd restart added
Actions #7

Updated by Lukas Zapletal almost 3 years ago

  • Triaged changed from No to Yes

Please increase the following values

#max_anonymous_clients = 20
#max_workers = 20

in /etc/libvirt/libvirtd.conf and restart libvirtd daemon. The libvirt daemon in RHEL is not configured for heavy concurrent client use, we generally do recomment oVirt or Red Hat Enterprise virtualization for enterprise workloads.

Actions #8

Updated by The Foreman Bot almost 3 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Lukas Zapletal
  • Pull request https://github.com/theforeman/foreman/pull/8652 added
Actions #9

Updated by Lukas Zapletal almost 3 years ago

  • Bugzilla link set to 1980166
Actions #10

Updated by The Foreman Bot over 2 years ago

  • Fixed in Releases 3.1.0 added
Actions #11

Updated by Lukas Zapletal over 2 years ago

  • Status changed from Ready For Testing to Closed
Actions

Also available in: Atom PDF