Bug #16550: Missing require on DataType in Param - Kafo - Foreman

Actions

Copy link

Bug #16550

closed

Missing require on DataType in Param

Added by Dominic Cleal over 7 years ago. Updated over 7 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Dominic Cleal

Difficulty:

Triaged:

Bugzilla link:

Pull request:

https://github.com/theforeman/kafo/pull/177

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description

The DataType class isn't available when called from lib/kafo/param.rb as the file isn't required. This causes a failure when using kafo-export-params:

/usr/bin/kafo-export-params -c config/foreman.yaml -f parsercache --no-parser-cache -o /builddir/build/BUILD/foreman-installer-1.14.0/_build/parser_cache/foreman.yaml
D, [2016-09-13T23:22:57.881737 #15996] DEBUG -- : Using Puppet module parser KafoParsers::PuppetModuleParser
/usr/share/gems/gems/kafo-1.0.0/lib/kafo/param.rb:14:in `initialize': uninitialized constant Kafo::Param::DataType (NameError)
    from /usr/share/gems/gems/kafo-1.0.0/lib/kafo/param_builder.rb:62:in `new'
    from /usr/share/gems/gems/kafo-1.0.0/lib/kafo/param_builder.rb:62:in `build'
    from /usr/share/gems/gems/kafo-1.0.0/lib/kafo/param_builder.rb:30:in `block in build_params'
    from /usr/share/gems/gems/kafo-1.0.0/lib/kafo/param_builder.rb:29:in `map'
    from /usr/share/gems/gems/kafo-1.0.0/lib/kafo/param_builder.rb:29:in `build_params'
    from /usr/share/gems/gems/kafo-1.0.0/lib/kafo/puppet_module.rb:79:in `parse'
    from /usr/share/gems/gems/kafo-1.0.0/lib/kafo/configuration.rb:89:in `block in modules'
    from /usr/share/gems/gems/kafo-1.0.0/lib/kafo/configuration.rb:89:in `map'
    from /usr/share/gems/gems/kafo-1.0.0/lib/kafo/configuration.rb:89:in `modules'
    from /usr/share/gems/gems/kafo-1.0.0/bin/kafo-export-params:149:in `print_out'
    from /usr/share/gems/gems/kafo-1.0.0/bin/kafo-export-params:51:in `execute'
    from /usr/share/gems/gems/clamp-1.0.0/lib/clamp/command.rb:68:in `run'
    from /usr/share/gems/gems/clamp-1.0.0/lib/clamp/command.rb:133:in `run'
    from /usr/share/gems/gems/kafo-1.0.0/bin/kafo-export-params:155:in `<top (required)>'
    from /usr/bin/kafo-export-params:23:in `load'
    from /usr/bin/kafo-export-params:23:in `<main>'

It seems it's only required from hook_context.