Bug #16617
open
Duplicate filters can be created
Description
Currently, there is no limitation, and multiple filters can be created for the same role (see attached image).
Files
Updated by Ohad Levy over 7 years ago
- Related to Tracker #16615: Permissions Usability Tracker added
Updated by Dominic Cleal over 7 years ago
- Category set to Users, Roles and Permissions
Please set the category on new bugs.
Not sure this is really a bug, filters are additive.
Updated by Ohad Levy over 7 years ago
Dominic Cleal wrote:
Not sure this is really a bug, filters are additive.
I can't see the reason why you would be able to create the exact same filter twice?
Updated by Marek Hulán over 7 years ago
- Status changed from New to Need more information
I don't think this should be considered as bug either. I think it would only introduce confusion why some filter can't be saved. Validation would have to be scoped per role so in the end user could still get 2 or more same filters from different roles. Is there some big advantage of enforcing uniqueness? Note that it would involve same permission set, same search condition, same override value and same taxonomies association checks.
Updated by Dominic Cleal over 7 years ago
- Related to Feature #17586: Remove duplicated permissions via migration added
Updated by Lukas Zapletal over 7 years ago
- Subject changed from duplicate filters can be created to Duplicate filters can be created
I offer an alternative solution, how about a button (or a rake task but that will be too hidden for users) that will simply remove dupes? I also think filters not being saved might be confusing experience so a way to clean things up might be a good option.
Updated by Anonymous about 7 years ago
- Status changed from Need more information to Needs design
Updated by Marek Hulán about 7 years ago
I agree with Lukas, "deduplicate" button might be useful even though I don't see many of duplicates. There used to be a bug that plugins were duplicating filters on every seed run but that's fixed for some time.