Feature #168
Make HOSTS fields optional when using "unattended"
| Status: | Assigned | Start: | 02/16/2010 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assigned to: |  Paul Kelly |
% Done: | 0% |
|
| Category: | Web Interface | |||
| Target version: | 0.1-6 | |||
| Branch: | feature/168-optional-fields |
Description
When using foreman with existing non-standard (legacy) machines and leaving "unattended = true" to use it for unattended installs for new machines, you get an error if you try to assign classes or groups and don't select a "Ptable" template.
The error is:
"Ptable Cant be blank unless a custom partition has been defined"
To manage this in a mixed environment I suggest not making the fields mandatory, but maybe just give a warning or confirmation saying that the fields are not completely filled up.
History
Updated by Ohad Levy 6 months ago
- Target version deleted (
0.1-4)
I agree this is a useful feature, I'll have to investigate how to implement it.
Updated by Ohad Levy 6 months ago
- Target version set to 0.1-5
ok, I've found a way to do it, I'll start working on towards the following release
Updated by Paul Kelly 3 months ago
- Status changed from New to Assigned
- Assigned to changed from Ohad Levy to Paul Kelly
I have implemented a mechanism for hiding and revealing the unattended section in the gui and using this to de/activate the relevant validation checks. However when testing I found that I was not able to find a scenario in which this problem could occur.
If a legacy host has been imported via the rake tasks then all host fields are populated except the media, ptable, root password and serial. If this host then requires a new class or group then this is accessed via the edit page. The edit page will populate the ptable field unless the operating system of the host does not have any partition tables defined for it. In this case it might be more sensible to change the error message to "Ptable Cant be blank unless a custom partition has been defined\nEnsure that operatingsystem XXX has at least one partition table defined." Alternatively, a custom validation could be created that could distinguish between these to situations.
Marcello: if you have access to a current development installation, could you confirm that this problem is still present? Could you also describe how your host entries were created? If you created them whilst unattended => false and then switched to using unattended => true I would expect to see more errors as mac is not set.
Updated by Paul Kelly 3 months ago
- Branch set to feature/168-optional-fields
Marcello: I think that I understand the problem now so no need to reply.
Rebased.
Tests pass
