Project

General

Profile

Actions

Bug #16913

closed

Validate format of dhcp-range option

Added by Stephen Benjamin over 7 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Category:
Foreman modules
Target version:
-
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1281743
Description of problem:
katello-installer with --capsule-dhcp-range is not able to set to default when using "false" or it doesn't check the syntax.

Version-Release number of selected component (if applicable):
6.1.3

How reproducible:
install satellite witch capsule and dhcp support

Steps to Reproduce:
1. After the satellite with capsule is installed, run:
2. katello-installer --capsule-dhcp-range "1 1" -> will fail, in the config
will be row like this: range "1 1"
3. katello-installer --capusle-dhcp-range false -> will fail, in the config
will be row like this: range false

Actual results:
There is wrong value for dhcp range

Expected results:
User receive an error message, when the syntax is not correct or in the case of "false", which supposed to be default, the range will be set to default

Actions #1

Updated by Dominic Cleal over 7 years ago

  • Project changed from Foreman to Installer
  • Subject changed from Validate format of dhcp-range option to Validate format of dhcp-range option
  • Category set to Foreman modules
Actions #2

Updated by Anonymous almost 7 years ago

Stephen, what's the status here with recent versions?

Actions #3

Updated by Ewoud Kohl van Wijngaarden almost 7 years ago

Looks like theforeman-dhcp doesn't use Puppet 4 types and theforeman-foreman_proxy accepts String. We could narrow this down to a Pattern to validate this.

Actions #4

Updated by The Foreman Bot over 6 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Ewoud Kohl van Wijngaarden
  • Pull request https://github.com/theforeman/puppet-dhcp/pull/112 added
Actions #5

Updated by Ewoud Kohl van Wijngaarden over 6 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF