Project

General

Profile

Actions

Feature #1717

open

Improve smart-variable unassignment during a puppetclass removal

Added by Olivier Favre almost 12 years ago. Updated over 9 years ago.

Status:
New
Priority:
Normal
Assignee:
Category:
Parameters
Target version:
-
Difficulty:
medium
Triaged:
Fixed in Releases:
Found in Releases:

Description

Smart-variables contain a lot of configuration we do not want to loose.
When a puppet class is deleted, the associated smart-variable are indeed not suppressed.
But the old puppetclass' id is still stored in the database.

NULL should be stored instead inside puppetclass_id.
Additionally, we should keep track of the last assigned puppetclass' name (when unassigning), as this would help identifying them.

Actions #1

Updated by Ohad Levy almost 12 years ago

cant we use auditing for that (instead of storing the class name?)

Actions #2

Updated by Olivier Favre almost 12 years ago

  • Status changed from New to Assigned
  • Assignee set to Olivier Favre
  • Estimated time changed from 1:00 h to 2:00 h
  • Difficulty changed from easy to medium
Actions #3

Updated by Olivier Favre almost 12 years ago

Ohad Levy wrote:

cant we use auditing for that (instead of storing the class name?)

Does that imply?:
  1. auditing puppetclass-lookup_keys association
  2. making a search in the audits if lookup_key.puppetclass == nil, extracting the name from the audits

We can make a second search in the audits to see the last destroy action associated with the old puppetclass id, but that assumes ids are never reused.

If this assumption does not hold, we would need to store the puppetclass name at the time of the dissociation, inside the audit record.

Actions #4

Updated by Tomer Brisker over 9 years ago

  • Status changed from Assigned to New
Actions

Also available in: Atom PDF