Project

General

Profile

Actions

Bug #17556

closed

ISC dhcpd provider potentially discards leases too early or too late

Added by Anonymous over 7 years ago. Updated about 7 years ago.

Status:
Rejected
Priority:
Normal
Assignee:
-
Category:
DHCP
Target version:
-
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

Time comparison on this line: https://github.com/theforeman/smart-proxy/blob/develop/modules/dhcp_isc/isc_state_changes_observer.rb#L65 can result in lease being discarded too early or too late due to difference in timezones: lease time is in UTC timezone, while Time.now returns current time in the local time zone.

Actions #1

Updated by Anonymous about 7 years ago

  • Status changed from New to Rejected

The comparison works correctly -- ruby automatically converts times on both sides of the comparison to the same timezone.

Actions

Also available in: Atom PDF