Project

General

Profile

Actions
Copy link

Refactor #18398

open

Use consistent naming of parameters in the DNS modules

Added by Ewoud Kohl van Wijngaarden over 7 years ago. Updated over 7 years ago.

Status:
Ready For Testing
Priority:
Normal
Assignee:
Ewoud Kohl van Wijngaarden
Category:
DNS
Target version:
-
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/smart-proxy/pull/507
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

This comes from https://github.com/theforeman/smart-proxy/pull/490. Currently the API uses parameter names like fqdn which are ambiguous, in particular in the context of a CNAME where both the name and content are FQDNs.

To avoid confusion I'm proposing to use the following naming scheme:

  • fqdn is what is defined in the API and should only be in dns_api.rb
  • value is what is defined in the API and should only be in dns_api.rb
  • name is the DNS name you query for
  • content is the result your DNS server should return

Related issues 1 (0 open — 1 closed)

Related to Smart Proxy - Refactor #17880: DNS CNAME parameters methods are swappedRejectedGuilherme Maluf Balzana12/29/2016Actions
Actions
Copy link
 #1

Updated by The Foreman Bot over 7 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/smart-proxy/pull/507 added
Actions
Copy link
 #2

Updated by Anonymous almost 7 years ago

  • Related to Refactor #17880: DNS CNAME parameters methods are swapped added
Actions
Copy link

Also available in: Atom PDF