Project

General

Profile

Actions

Bug #21032

closed

logrotate conflict: foreman-proxy and tfm-rubygem-smart_proxy_dynflow_core

Added by Radosław Piliszek over 6 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
RPMs
Target version:
-
Difficulty:
Triaged:
No
Fixed in Releases:
Found in Releases:

Description

Foreman 1.15.4 (1.15.2 was the latest selectable as "found in")

/etc/logrotate.d/foreman-proxy controls /var/log/foreman-proxy/*log and foreman-proxy service is signaled when rotation happens.
/etc/logrotate.d/tfm-rubygem-smart_proxy_dynflow_core controls /var/log/foreman-proxy/smart_proxy_dynflow_core.log and smart_proxy_dynflow_core service is signaled when rotation happens.

There is a conflict that logrotate catches:

error: tfm-rubygem-smart_proxy_dynflow_core:1 duplicate log entry for /var/log/foreman-proxy/smart_proxy_dynflow_core.log

and ignores the /etc/logrotate.d/tfm-rubygem-smart_proxy_dynflow_core configuration (smart_proxy_dynflow_core service is never signaled and foreman-proxy service is signaled for its log instead).


Related issues 1 (0 open1 closed)

Related to foreman-tasks - Bug #19224: smart_proxy_dynflow_core.log not reopened during logrotateClosedAdam Ruzicka04/07/2017Actions
Actions #1

Updated by Radosław Piliszek over 6 years ago

Related to Issue #19223, fixing this will cause the same symptoms as in that issue but for smart_proxy_dynflow_core service. Both have to be fixed to restore proper smart_proxy_dynflow_core logging.

Actions #2

Updated by Radosław Piliszek over 6 years ago

Also it looks like Issue #19224 was supposed to be the one where this was fixed but it had been closed prematurely (the behaviour was not corrected then).

Actions #3

Updated by Lukas Zapletal over 6 years ago

For the record, the team is dicussing if SIGHUP is a good signal to support or not. Otherwise the only change is to rewrite policy:

https://github.com/theforeman/smart-proxy/pull/544

If this is accepted, lets move this to dynflow project and make the very same change there. Here:

https://github.com/theforeman/foreman-packaging/blob/rpm/develop/rubygem-smart_proxy_dynflow_core/logrotate.conf

And here:

https://github.com/theforeman/smart_proxy_dynflow/blob/master/deploy/smart_proxy_dynflow_core.service

Actions #4

Updated by Lukas Zapletal over 6 years ago

  • Related to Bug #19224: smart_proxy_dynflow_core.log not reopened during logrotate added
Actions #5

Updated by Radosław Piliszek over 6 years ago

You are right about that, Lukas, but you missed the fact that there is yet another layer of problems: the conflict between files in the same directory. Dynflow's log must be placed somewhere else.

Actions #6

Updated by Radosław Piliszek over 6 years ago

... or foreman-proxy logrotate config must watch less files.

Actions #7

Updated by Ewoud Kohl van Wijngaarden over 2 years ago

  • Status changed from New to Closed

The smart_proxy_dynflow_core package has been obsoleted and is no longer shipped.

Actions

Also available in: Atom PDF