Project

General

Profile

Actions

Bug #21654

closed

Host discovery fails with undefined method `new` for nil:NIlClass

Added by Lukas Zapletal over 6 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Facts
Target version:
-
Difficulty:
trivial
Triaged:
No
Fixed in Releases:
Found in Releases:

Description

The problem is that in the old (pre-PR) code importers registry is kept in FactImporter class that gets reloaded. Once the class is reloaded, it looses its default importer registration that point to puppet. See my comment for more information.

This is a regression in the import_facts core codebase introduced by #15409.

Let's add one REAL (non-mocked) test of discovering a host :-)


Related issues 4 (0 open4 closed)

Related to Discovery - Bug #21653: Unable to render host without memory infoClosedOri Rabin11/14/2017Actions
Related to Katello - Bug #22705: Must use the ImporterRegistry rather than FactImporterClosedRahul BajajActions
Related to Foreman - Bug #21573: Importing facts in development breaks on code reloadDuplicateActions
Related to Foreman - Bug #34026: Importing puppet report via the API does not authorizeClosedLukas ZapletalActions
Actions #1

Updated by Rahul Bajaj over 6 years ago

  • Assignee set to Rahul Bajaj
Actions #2

Updated by Lukas Zapletal over 6 years ago

  • Related to Bug #21653: Unable to render host without memory info added
Actions #3

Updated by Lukas Zapletal over 6 years ago

As per IRC, the issue is in Host::Base#import_facts:

type = facts.delete(:_type)

It was previously:

type = facts.delete(:_type) || 'puppet'
Actions #4

Updated by Rahul Bajaj about 6 years ago

  • Project changed from Discovery to Foreman
  • Category deleted (Discovery plugin)
Actions #5

Updated by Rahul Bajaj about 6 years ago

  • Pull request https://github.com/theforeman/foreman/pull/5010 added
Actions #6

Updated by Rahul Bajaj about 6 years ago

  • Related to Bug #22705: Must use the ImporterRegistry rather than FactImporter added
Actions #7

Updated by The Foreman Bot about 6 years ago

  • Status changed from New to Ready For Testing
Actions #8

Updated by Lukas Zapletal almost 6 years ago

  • Triaged set to No

It looks like this happens only when Rails reloads some classes: #21573

Actions #9

Updated by Lukas Zapletal almost 6 years ago

  • Related to Bug #21573: Importing facts in development breaks on code reload added
Actions #10

Updated by Lukas Zapletal almost 6 years ago

  • Description updated (diff)
Actions #11

Updated by The Foreman Bot about 4 years ago

  • Fixed in Releases 2.1.0 added
Actions #12

Updated by Rahul Bajaj about 4 years ago

  • Status changed from Ready For Testing to Closed
Actions #13

Updated by Tomer Brisker almost 4 years ago

  • Category set to Facts
Actions #14

Updated by Lukas Zapletal over 2 years ago

  • Related to Bug #34026: Importing puppet report via the API does not authorize added
Actions

Also available in: Atom PDF