Bug #23291: Proxy template URL not used for kickstart - Foreman

Actions

Copy link

Bug #23291

closed

Proxy template URL not used for kickstart

Added by Adam Ruzicka about 6 years ago. Updated over 5 years ago.

Status:

Closed

Priority:

High

Assignee:

Arend Lapere

Category:

Templates

Target version:

Difficulty:

Triaged:

Bugzilla link:

1624072

Pull request:

https://github.com/theforeman/foreman/pull/5822, https://github.com/theforeman/foreman/pull/5852, https://github.com/theforeman/foreman/pull/5853

Fixed in Releases:

1.18.1, 1.19.0

Found in Releases:

1.18.0-RC1, 1.18.0-RC2, 1.18.0-RC3

Red Hat JIRA:

Description

Steps to reproduce:
1) Have a smart-proxy with templates feature
2) Set template_url to use http in /etc/smart-proxy/settings.d/templates.yml
3) Assign the proxy to a subnet as template proxy
4) Try to provision a host in subnet from step 3

Actual result:
The host tries to access the proxy over the https and fails because CA used to signed the proxy's certificate is not trusted

Expected result:
template_url is honored and provisioning doesn't fail

After observing the log, we noticed that the base url is trying to access the templateServer API on the wrong URL: https://<proxy>:8443/unattended*/unattended* while it should be https://<proxy>:8443/unattended

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Arend Lapere almost 6 years ago

Triaged set to No

Hello,

Could it be that you are running into this on 1.18-RC1/2/3?

I've investigated a bit, and seems this patch-set is the culprit:
https://github.com/theforeman/foreman/commit/009e7bbd29f31c3750a8be47b4aecf5278c0db95#diff-1b99c484fd9f41096d5029e5b20d6165

This creates the Template class twice (and appends the "/unattended" string to the URL):
- Once initiated when retrieving Subnet.template_proxy
- This template_proxy is than passed to the second instantiation, done in foreman_url_rendered, which is needed to retrieve actual templateServer from the proxy.

To validate, I've removed the instance in app/models/subnet.rb:181 and simply returned the template variable, after this, all seems to behave as expected.

Although the latter is probably not the answer, as it seems to be more in line with the rest of the modules (e.g. DNS, BMC, ...).

Actions

Copy link