Project

General

Profile

Actions

Bug #23785

closed

Do not log large response bodies

Added by Thomas McKay almost 6 years ago. Updated almost 6 years ago.

Status:
Duplicate
Priority:
Normal
Assignee:
Category:
Container
Target version:
Difficulty:
Triaged:
Yes
Fixed in Releases:
Found in Releases:

Description

The concerns/api/api_controller.rb has a debug statement in process_action method. When docker pull directly against server (not crane :5000) the blobs (large binary data) is logged. Needs to be a way to either override this method or skip large bodies.


Related issues 1 (0 open1 closed)

Related to Katello - Bug #24370: PUT requests content is logged in info levelClosedThomas McKayActions
Actions #1

Updated by John Mitsch almost 6 years ago

  • Category set to Container
  • Assignee set to Thomas McKay
  • translation missing: en.field_release set to 349
Actions #2

Updated by Stephen Benjamin almost 6 years ago

Also happens for uploading packages/puppet modules, really ugly:

16:41:24 rails.1   | 2018-06-14T16:41:24 [D|app|e1d01] Setting current user thread-local variable to admin
16:41:24 rails.1   | 2018-06-14T16:41:24 [I|kat|e1d01] PUT: https://centos7-devel.zpm.example.com/pulp/a露
C�۾/�R]��j����S���L\��u<��5��;Or���h��ղ��v'��VWWWU�e���e:uܤ>�R��jl5��ݧ��6���k�m��j��~����f���t�_{��D�DZ�Y$߬͜�
Actions #3

Updated by Thomas McKay almost 6 years ago

  • Status changed from New to Duplicate
Actions #4

Updated by Anonymous almost 6 years ago

  • Related to Bug #24370: PUT requests content is logged in info level added
Actions #5

Updated by Stephen Benjamin almost 6 years ago

  • Status changed from Duplicate to New

Not a duplicate. The fix in #23835 only fixes one case. Uploading RPM's, files, etc to a repository still get logged.

Actions #6

Updated by Stephen Benjamin almost 6 years ago

  • Status changed from New to Duplicate

Er nevermind, just leave this is a duplicate and #24370 can be used for repository uploading.

Actions #7

Updated by Samir Jha almost 6 years ago

  • Target version changed from Katello 3.8.0 to Katello Recycle Bin
Actions

Also available in: Atom PDF