Project

General

Profile

Actions

Bug #24046

closed

Foreman's HasManyCommon concern uses 'id' for a method Rails expects to return a string

Added by Stephen Benjamin almost 6 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Category:
Rails
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

Foreman HasManyCommon concern uses 'id' as a value of last resort for the name of an attribute. But Rails expects this value to a return a string. This causes a problem for Katello. Take a look at the output here in Katello:

irb(main):001:0> Host.first
Hirb Error: undefined method `gsub' for 2:Integer
</rep>

Where's that coming from?

<pre>
irb(main):006:0> Host.first.content_facet_attributes.to_s
=> 2
irb(main):007:0> Host.first.content_facet_attributes.to_s.is_a?(String)
=> false
</pre>

Foreman should use a method that returns string as a last resort.
Actions #1

Updated by The Foreman Bot almost 6 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Stephen Benjamin
  • Pull request https://github.com/theforeman/foreman/pull/5732 added
Actions #2

Updated by Tomer Brisker almost 6 years ago

  • translation missing: en.field_release set to 353
Actions #3

Updated by Stephen Benjamin almost 6 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF