Project

General

Profile

Actions

Bug #29496

closed

Relying on query string parsing breaks client-side pagination

Added by Ondřej Pražák about 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Category:
JavaScript stack
Target version:
-
Difficulty:
Triaged:
No
Fixed in Releases:
Found in Releases:

Description

Pagination component directly calls helpers to parse page url and if 'perPage' is not found in query string, it uses default page size from settings with no option to override via props. This makes the component very inflexible as it is now tied to browser url. As a side effect, this breaks client-side pagination on pages where Pagination component is used.

Steps to reproduce:
1) sync templates using foreman_templates plugin
2) change number of entries per page when sync result is displayed
3) the correct number of entries is displayed, but pagination shows incorrect numbers


Related issues 1 (0 open1 closed)

Related to Foreman - Feature #28148: Add react context provider ClosedAmir FeferActions
Actions #1

Updated by Ondřej Pražák about 4 years ago

Actions #2

Updated by The Foreman Bot about 4 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/7573 added
Actions #3

Updated by The Foreman Bot about 4 years ago

  • Fixed in Releases 2.1.0 added
Actions #4

Updated by Ondřej Pražák about 4 years ago

  • Status changed from Ready For Testing to Closed
Actions #5

Updated by Amit Upadhye about 4 years ago

  • Category set to JavaScript stack
Actions

Also available in: Atom PDF