Project

General

Profile

Actions
Copy link

Bug #31399

closed

Snapshot tests must take plugins into consideration

Added by Lukas Zapletal over 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Lukas Zapletal
Category:
Templates
Target version:
-
Difficulty:
Triaged:
Yes
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/8143, https://github.com/theforeman/foreman/pull/8158
Fixed in Releases:
2.5.0
Found in Releases:
Red Hat JIRA:

Description

Some templates render different output when a plugin is enabled/disabled:

https://github.com/theforeman/foreman/blob/develop/app/views/unattended/provisioning_templates/provision/preseed_default.erb#L11

We either need to stub this call to return always false or true.

Actions
Copy link
 #1

Updated by The Foreman Bot over 3 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/8143 added
Actions
Copy link
 #2

Updated by The Foreman Bot over 3 years ago

  • Pull request https://github.com/theforeman/foreman/pull/8158 added
Actions
Copy link
 #3

Updated by The Foreman Bot about 3 years ago

  • Fixed in Releases 2.5.0 added
Actions
Copy link
 #4

Updated by Lukas Zapletal about 3 years ago

  • Status changed from Ready For Testing to Closed
Actions
Copy link

Also available in: Atom PDF