Bug #3610: --reset-db error detection does not work - Installer - Foreman

Actions

Copy link

Bug #3610

closed

--reset-db error detection does not work

Added by Marek Hulán over 10 years ago. Updated over 10 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Marek Hulán

Category:

Target version:

Difficulty:

Triaged:

Bugzilla link:

Pull request:

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description

The problem is that rake db:drop returns 0 even when there are errors. We should detect whether anything was on STDOUT and in such case report a warning otherwise suppose it ran ok.

Actions

Copy link

Updated by Marek Hulán over 10 years ago

Project changed from Kafo to Installer
Status changed from New to Assigned
Assignee set to Marek Hulán

Actions

Copy link

Updated by Marek Hulán over 10 years ago

This won't be that easy because there can be deprecation warnings on STDOUT (from fog atm) and STDERR can contain warnings like "program compiled against libxml 209 using older 208".

I think the only correct solution is to wait until this PR gets merged https://github.com/rails/rails/pull/12531 which is targeted 4.1.0 (unless they backport it). Meanwhile we should document this somehow?

Actions

Copy link

Updated by Greg Sutcliffe over 10 years ago

I think documentation is fine while we wait.

Actions

Copy link

Updated by Marek Hulán over 10 years ago

Status changed from Assigned to New

Explanation is now part of installer help - see https://github.com/theforeman/foreman-installer/pull/78. Moving this to new status until rake db:drop returns meaningful error code.

Actions

Copy link