Project

General

Profile

Actions

Bug #37251

closed

adapt foreman_puppet tests to run with remote_webdriver

Added by dosas please_edit_me 3 months ago. Updated 2 months ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Target version:
-
Difficulty:
Triaged:
No
Fixed in Releases:
Found in Releases:

Description

When executing foreman_puppet integration tests with the remote webdriver https://github.com/theforeman/foreman/pull/9952

I get the following error:

```
test_0005_edit page(Minitest::Result) [/builds/Engineering/orcharhino/dependencies/foreman_puppet/foreman/vendor/ruby/ruby/2.7.0/gems/selenium-webdriver-4.9.0/lib/selenium/webdriver/remote/bridge.rb:411]:
Selenium::WebDriver::Error::WebDriverError: You are trying to work with something that isn't a file.
foreman_puppet/test/integration/foreman_puppet/smartclass_parameter_js_test.rb:77:in `block in <class:SmartclassParameterJSTest>'

```

In this file https://github.com/theforeman/foreman_puppet/blob/master/test/integration/foreman_puppet/smartclass_parameter_js_test.rb#L77
```
fill_in 'puppetclass_lookup_key_description', with: 'test'
```
Is looking for a file called test

AFAIK there are to possibilities to fix this:

1. Disable the file detector for this test
```
page.driver.browser.file_detector = nil if page.driver.browser.respond_to?(:file_detector=)
```

2. Change fill_in to something that isn't a file
```
fill_in 'puppetclass_lookup_key_description', with: 'asdf'
```

Let me know which one you prefer then I can open a PR

Actions #1

Updated by The Foreman Bot 3 months ago

  • Pull request https://github.com/theforeman/foreman_puppet/pull/392 added
Actions #2

Updated by The Foreman Bot 2 months ago

  • Fixed in Releases 1.0 added
Actions #3

Updated by dosas please_edit_me 2 months ago

  • Status changed from New to Closed
Actions

Also available in: Atom PDF