Project

General

Profile

Actions

Refactor #8426

closed

Move scoped search into concerns

Added by Daniel Lobato Garcia over 9 years ago. Updated over 9 years ago.

Status:
Rejected
Priority:
Normal
Category:
Search
Target version:
-
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

Scoped search definitions can be cumbersome at times and don't really define the business logic of a model. I think hiding them under the carpet by moving most of the definitions to concerns (as we do with hostext) we can later on include would keep the code cleaner. There are 3 or 4 models with just 1 scoped_search attribute I didn't bother to move, later commits that move them into concerns when they become bigger can just ref this issue.

Actions #1

Updated by The Foreman Bot over 9 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/1952 added
  • Pull request deleted ()
Actions #2

Updated by Dominic Cleal over 9 years ago

  • Category set to Search
  • Assignee set to Daniel Lobato Garcia
Actions #3

Updated by Daniel Lobato Garcia over 9 years ago

  • Status changed from Ready For Testing to Closed
Actions #4

Updated by Daniel Lobato Garcia over 9 years ago

  • Status changed from Closed to Rejected
Actions

Also available in: Atom PDF