Project

General

Profile

Actions

Bug #990

closed

wrong error message when looking for puppetca certificate list

Added by Ohad Levy almost 13 years ago. Updated about 8 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
PuppetCA
Target version:
-
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

this happens when the proxy is not reachable:

undefined method `map' for true:TrueClass
Actions #1

Updated by Paul Kelly almost 13 years ago

  • Category set to PuppetCA
  • Status changed from New to Feedback
  • Assignee set to Ohad Levy

When I stop the smart-proxy and then http://localhost:3000/smart_proxies/5/puppetca I get this message
Connection refused - connect(2)
Hardly elegant but certainly correct.
Could you see try this operation again?

Actions #2

Updated by Ohad Levy almost 13 years ago

  • Assignee changed from Ohad Levy to Paul Kelly

the main issue here (at least for the first error) is that the proxy library code checks the return code and the return length,
if its smaller then 2 it returns a true object.

any idea why we do that?

Actions #3

Updated by Paul Kelly almost 13 years ago

the smallest valid reply is "{}", which is two characters. JSON.parse chokes on anything less than two characters.
I guess it is trying to say:-
I got a valid rely cos the code says ok
return the value that we got or say that we succeeded in doing whatever we were asked.

A delete operation returns nothing.

Actions #4

Updated by Ohad Levy almost 13 years ago

Paul Kelly wrote:

the smallest valid reply is "{}", which is two characters. JSON.parse chokes on anything less than two characters.
I guess it is trying to say:-
I got a valid rely cos the code says ok
return the value that we got or say that we succeeded in doing whatever we were asked.

A delete operation returns nothing.

yeah, but in this case, it returns simply true, which is wrong... can we look into it again?

Actions #5

Updated by Ohad Levy over 12 years ago

  • Target version deleted (0.4)
Actions #6

Updated by Benjamin Papillon over 11 years ago

  • Status changed from Feedback to New
Actions #7

Updated by Greg Sutcliffe about 8 years ago

  • Description updated (diff)
  • Status changed from New to Resolved

This is no longer valid in 1.12-develop - the UI will correctly say that it can't contact the proxy.

Closing this, re-open if necessary :)

Actions

Also available in: Atom PDF