Refs #22058 - refresh rubocop config and apply autofixes
Fixes #23857 - Fix Performance/InefficientHashSearch cop
Fixes #13749 - Handle Base64 and binary LDAP avatars
Before this change, we would always try to Base64.decode absolutely anyavatar. This resulted in broken images, as sometimes the avatars areautomatically turned into binary by net/ldap. In such cases, we want to...
Fixes #19840 - Fix Rails/ReadWriteAttribute cop
Fixes #15286 - New API for auth sources (#4865)
Fixes #19772, #19773, #19774 - Fix some empty line cops
Fixes #17992, #18103 - Improve external usergroup errors
When one submit an user group with external user groups, and thisdoesn't work for whatever reason, like:
Net::LDAP::Error - No route to host - connect(2)LdapFluff::Generic::UnauthenticatedException...
fixes #21394 - user login with access token api
Fixes #21175 - Unable to add AD LDAP Auth Source
Fixes #20515 - always find user by login
Fixes #17811 - Improve error message LDAP fail
Fixes #16112 - support for netgroups in LDAP auth source
Fixes #16624 - Make AuthSourceLDAP taxable
This allows users to set organizations/locations on AuthSourceLDAPobjects. That in itself might not be that useful, but it allows us tofollow on and assign the AuthSourceLDAP taxonomies to the usersautocreated through it.
Fixes #16491 - Upgrade rubocop to version 0.42
fixes #3917 - replace protected_attrs with strong parameters
Filtering of attributes has moved from the protected_attributes gem tostrong parameters in controller concerns, to be in line with currentRails recommendations.
Concerns are shared between UI and both API controllers and list the...
Refs #3809 - Turning on some rubocop cops
Refs #12911 - Fixing colon method calls
fixes #12730 - removing the fakeFS gem
fixes #7548 - cannot use UTF8 characters from ldap auth source
Fixes #7568 - Use attr_accessible for Rails 4 upgrade
Fixes #12325 - Add to_utf8 method and ensure avatar_path returns in utf-8
Fixes #7537 - Adds test connection button to LDAP form
Fixes #12059 - AuthSourceLdap allow_nil should be removed
When we migrated to the new migration syntax, the clause`validate_length_of :host` was wrongly translated. It contains a clause`allow_nil` that allows it to be nil, but in Rails 3 the `:presence =>...
Fixes #11407 - Uppercase logins from LDAP break external user group sync
On LDAP the login can contain uppercase chars, for instance, "FOO". Howeverwhen we log in Foreman for the first time and have that account auto-created,we can login using "foo". After that, our login will be saved as "foo" on...
Fixes #11428 - External user groups refresh shouldn't be case sensitive
group_list in ldap_fluff returns a list of lowercase LDAP GIDs.When AuthSourceLdap tries to run update_usergroups to refresh the externaluser groups, it will try to match these lowercase gids with external user...
Fixes #10713 - improved backtrace logging
fixes #10509 - add toggle for LDAP usergroup updating
fixes #10493 - disable usergroup sync on login when $login is used
fixes #4769 - fix deprecation warning while syncing LDAP attrs
fixes #10406 - add LDAP instrumentation and extra logging
Fixes #10263 - Encrypt LDAP password in db
This commit includes a rake task to encrypt all encryptable resources.A helper function can be used to add more encryption tasks easily.
Fixes #9926 - do not always set LDAP encryption method
Fixes #9885 - pass verify_mode to net/ldap
Fixes #9869 - propagate LDAP errors
Refs #3809 - Remove cops for empty lines
fixes #9084 - catch net-ldap 0.11's specific invalid filter exception
Refs #3809 - Remove useless assignments
Fixes #7369 - External user groups update on login
Fixes #6710 - unicode characters in url parameters
Original methods to_param defined on resources called name.parameterizeto get rid of url-unsafe characters. This function unfortunately alsostripped off unicode characters.
Changes:- parameterization extracted into a separate module Parameterizable...
fixes #7898 - ensure that format can respond to json / yaml
fixes #4439 - ensure user logins are handled case insensitively
Refs #3809 - Use parentheses in method definitions
fixes #4386 - gem friendly_id to simplify find by id, name, label, etc
Fixes #6538 - User group vs usergroup name consistency
refs #7066 - fix syntax error in expression
fixes #7066 - add back $login interpolation for LDAP service account usernames
In cases where an LDAP connection is required outside of the context of userauthentication (e.g. validation of external user group name), an error isthrown. Users are recommended to use dedicated service accounts for this...
Fixes #7003 - Revert LDAP to simple_tls
Fixes #5734 - API for external groups management
Fixes #813 - External usergroups can be linked to an LDAP auth source
fixes #6636, #6657, #6694 - add field length validations, extend audit field length
fixes #5414: LDAP + TLS is not LDAP + TLS but LDAP + SSL and changed port automatically on check
fixes #3272 - allow 'admin' account to be removed and replaced
fixes #5222 - Log ldap attributes in debug-level logging
fixes #4643 - Retrieving Optional LDAP attributes fails on 1.8.7
fixes #3827 - adds ldap avatar support
fixes #4442 - returning nil plays nice with try_to_login.
fixes #3312 - support /users/extlogin as a login page based on REMOTE_USER
fixes #2741 - rails 3 syntax
fixes #863 - added ldap_filter to LDAP auth sources to filter lookups using RFC 2254 filters
fixes #2411 - move STI models in /models and /lib/foreman/models to sub-folders