Fixes #19789 - fix Layout/SpaceAroundOperators cop

fixes #23909 - vsphere: prefer network search by key

Creating a new VMware image fails during provisioning with
"Could not match network interface". Searching for distributed
virtual switch via key BEFORE searching with the nic_attrs structure
resolves a false positive match when vCenter contains VDS migrated...

Fixes #19839 - Fix Rails/Present cop

Fixes #22331 - Fix Rails/Presence cop

Fixes #19907 - Configure Style/TernaryParentheses cop

Fixes #21675 - OpenStack create host tab fails to load

Currently the tab is not loading as there are a few methods that are not
being overridden properly by the FogExtension.

After fixing that and adding the metadata key the tab loads

Fixes #20957 - Replace alias_method_chain with Module prepend

Deprecated in Rails 5.0 and will be removed in 5.1. Some instances of
classes overwriting existing methods can be handled with `super`, other
concerns or modules are changed to use prepend instead of include....

Fixes #19113 - use fog-ovirt method for rebooting

While fixing the waiting for stopped vm in reboot there.

refs #19623 - fix if key method is not present for network

credit to jsherrill for the one line solution :)

Fixes #19623 - add comparison to portkey for vmware networks

fixes #19419 - fix invalid syntax in aws fog extention

Fix invalid syntax in server.rb

fixes #18064 - import host from compute resource

Fixes #5483,#11106 - pass the virtualswitch value to fog

We can't pass the network id directly to the fog, but it accepts the
virtualswitch parameter, that we can use to point to the right value.

Also, it fixes another issue, where we used the vsphere network id to...

fixes #17340 - assign IPv6 address to Rackspace CR hosts

Fixes #16737 - Show correct folder level

Fixes #2314 - fine grain for RAM selectors

Fixes #15924 - Implement server groups and scheduler hints

Refs #3809 - Turning on the AndOr cop

fixes #3910 - add cdrom drive support for vmware

Fixes #15151 - properly convert Fog VMs to_s

Useful for power action pop up alerts to avoid the nasty inspection
strings.

Refs #3809 - Turning on some rubocop cops

Fixes #13557 - Rubocop enforce specifying a timezone

Rubocop can enforce what timezone to store in the database ,
so we can ensure everything is stored using UTC and we don't
miss these things in code reviews. When objects are displayed,
they must use the time provided by set_timezone in the...

Fixes #12523 - Openstack does not work with Fog 1.36

Problem:
In a recent refactor of Openstack in Fog, defining @identity_connection
was moved to a class method. This causes it to be unavailable in
instances of Fog::Compute::Openstack::Real which we use to retrieve...

Refs #3809 - Enable Rails delegate cop

Fixes #4551 - GCE provisioning support

Enable provisioning of VMs through Google Compute Engine. Volume-wise,
this is currently limited to creating a VM with an attached disk that
contains the image specified. Future enhancements should include
choosing any available disks to auto-attach the VM and not force the...

fixes #10261 - update fog to 1.30.0

fixes #10030 - use override method to display templates in folders

Fixes #10186 - find host NICs on vsphere using Network Distributed PortGroup

refs #4521 - Openstack Compute Resource: Boot from Volume on new Host

fixes #6568 - showing ovirt template version if applicable

Refs #3809 - Remove cop IndentationConsistency

Refs #3809 - Remove cops for empty lines

Fixes #7456 - Extract primary interface from host

• Tomas Strachota (tstrachota) <tstrachota@redhat.com>
• Marek Hulán (ares) <mhulan@redhat.com>
• Gregory Sutcliffe (GregSutcliffe) <gsutclif@redhat.com>

All host must have at least one primary interface and one provision (can...

Fixes #8796 - Fix to_gb size calculation and constentize

fixes #8356 - refactor reset method for libvirt

Fixes #746 - Generate all the Host template when click on Build to avoid errors during installation

Refs #3809 - Use parentheses in method definitions

Refs #3809 - Fix a few rubocop TODOs

fixes #3902 - [Openstack] allow selection of internal networks

This patch allows the user to select the internal network when deploying
a new instance in openstack.

In Grizlly, this was done automaticilly, with a nasty side effect, that
all internal networks would get assigned (didnt see that as i had only...

fixes #5119 - ensure GCE can list images.

fixes #4590 - convert VMware SCSI controller type during creation

fixes #5132 hang when provisioning on ovirt 3.4

Fixes #4710, #2270 - Wait for VM to become ready before looking for IPs

fixes #2438 - Add image build capability to vsphere using templates

Fixes #4616 - Add a Fog mixin for looking up EC2 IP addresses

fixes #4123 - libvirt imaging support using backing volumes

fixes #4015 - support oVirt using templates like images

fixes #3496 vSphere: add support for selectable SCSI controller

fixes #3980 - Compute profiles not rendering Openstack attributes correctly

fixes #3178 - add feature for compute profiles for hostgroups and hosts

fixes #3698 - add image_id alias to server resource as form uses it

fixes #1719 - Add support for GCE

fixes #1871, #1879 - add VPC support to EC2 compute resource

Based on patch from Romain Vrignaud <romain@yakaz.com>

fixes #2891 Openstack power control operations support

Compute resource helper Strings should be possible to translate

Compute resource permission to pause vms

Tests for Openstack VM pausing/resuming

VMs UI shows only available actions

I18n string issues. Vm power state cannot be properly translated yet...

fixes #2411 - move lib/audit_extensions lib/fog_extensions lib/foreman to models/concerns

fixes #2739 - add ActiveSupport::Concern syntax to mixins