Refs #3809 - Stabby lambda syntax for oneliners

I started by spotting log.rb which didn't have a lambda wrapping its
default scope, as needed by Rails 4. Since the style guide and most
Rails 4 documents used the stabby lambda, I turned on the cop so that we...

Fixes #11031 - ignore identifiers of interfaces being destroyed

Fixes #1453 - add use_image and jumpstart helpers to Host jail

Fixes #9591 - Added support for "inherit" state.

Refs #3809 - Enable cop Style/IfUnlessModifier

Fixes #11035 - template preview feature

Fixes #10915 - Deleting a host removes all host specific overrides

Fixes #10635 - Formalize deprecation warning

Fixes #10607 - match bonds based on identifier only

Fixes #10888 - skip attached_to updates if identifier was blank

Fixes #10633 - Associate architechture to OS during fact import

fixes #10861 - Remove unused columns from the hosts table

• Serial - Never really used, probably can be refactored as kernel
  parameters.
• last_freshcheck, source_file_id - left overs from puppet old store
  configs compatibility that we no longer use, I assume no one is using...

fixes #10627 - apply host taxonomy scope to facts/report joins

Previous changes to perform a join onto hosts with authorisation result
in a query such as Report.joins(:hosts), which ignores any
default_scope on Host::Base. This commit explicitly passes taxonomy...

Fixes #10713 - improved backtrace logging

• full trace in 500 page in production shows really the full trace
• Foreman::Logging.exception as an unified entry point for exceptions logging
• the backtrace cleaner doesn't delete the plugins
• the orchestration exceptions gets the backtrace covered by logger...

Fixes #7096 - Adds STI to templates

This commit converts Ptables to be just another type of Template so it
gets the same features as ConfigTemplate. ConfigTemplate was renamed to
ProvisioningTemplate to reflect UI and the name under it's commonly known.

fixes #10720 - Adds API to get host vm attributes

This exposes an API to fetch a host's vm_compute_attributes,
such as vmware cpus and memory. It lives at a separate endpoint
because it involves a fetch for data from the compute resource,
and may have different performance characteristics than the database.

fixes #9301 - make puppet environment optional for hosts

fixes #6332 - skip taxonomy queries when features are disabled

fixes #1510 - notification when host finishes building

Fixes #10535 - building a token instead of creating it until host is saved

Fixes #10212 - validate DNS name uniqueness of interfaces

fixes #10403 - resync names of unmanaged hosts to their primary NIC

MoveHostNicsToInterfaces previously ignored unmanaged hosts, but they
need migrating too. Updated the existing migration to migrate both,
then for existing hosts, add a new migration to ensure all primary NIC...

Fixes #10307 - editing host with 'unattended: false' no longer results in error

fixes #10298 - handle destroyed but present interfaces

When deleting a host and DHCP orchestration is removing reservations for NICs,
it generates a dhcp_record that contains next-server data. Determining the
next-server IP causes the primary interface to be fetched for DNS resolution,...

Refs #10337 - Update Host searches to use outofsync_interval

Fixes #10337 - Added setting out of sync duration

fixes #10168 - delegate fqdn/shortname to primary interface

Fixes #10111 - Use a dummy primary interface for unmanaged hosts

Unmanaged hosts require a host interface due to delegation of networking
attributes, and some others like 'name'. Since unmanaged hosts do not
necessarily have an interface associated (unless created through puppet...

fixes #9993 - Removes root password and partition table reqs unless build mode selected

Fixes #10025 - move generic taxonomies code to base class

Fixes #9947 - restrict user taxonomies if none is set

Fixes #8890 - Allow selection of plaintext "encryption" method for root password

Fixes #9618 - make identifier uniq per host

Fixes #8316: Removing a host can create a huge transaction

fixes #8878 - ensure domain fact is downcased prior to import

Fixes #9590 - make info test less fragile

Refs #3809 - Remove cop IndentationConsistency

Refs #3809 - Remove cops for empty lines

Fixes #9186 - build interface if needed during facts import

Fixes #9104 - allow disabling of interface updates

Fixes #7456 - Extract primary interface from host

• Tomas Strachota (tstrachota) <tstrachota@redhat.com>
• Marek Hulán (ares) <mhulan@redhat.com>
• Gregory Sutcliffe (GregSutcliffe) <gsutclif@redhat.com>

All host must have at least one primary interface and one provision (can...

fixes #8498 - Allows root password to be set in finish scripts

Refs #9049 - fix log message formatting

Missing "%s" in the commit that was supposed to fix #9049 caused the
exception message not to be printed into the log.

Fixes #2948 - added sp_* host attributes to safe mode

Refs #2948 - Add sp_ host attributes to jail test

Fixes #9044 - fixes invalid mac in tests

Also do not reset invalid mac address to nil so we can propagate proper
validation error.

Fixes #9049 - Log exceptions when triggering a Puppet run

If an exception occurs during triggering a Puppet run from the UI,
user will be notified of the error in a flash message. If the
exception occurs when running the action non-interactively (e.g. from...

fixes #6369 - allow to override puppet ca/master to nil

fixes #8739 - use global setting when hostgroup root_pass is blank

A blank (not nil) root_pass on hostgroups was preventing correct inheritance
from settings in both hosts and nested hostgroups.

root_pass was also being copied from parents/settings to hostgroups when they...

Fixes #8546 - Namespace interfaces and subnets to avoid a facts clash

Fixes #7440 - correctly autocomplete current_user

Fixes #8456 - normalize addresses only if mac is being set

Fixes #7908 - normalize mac before host get saved

For some reason we save host without running valdiations when we import
attributes from facts. Therefore we have to take care of mac
normalization by ourselves. We have to normalize it just after setting
new value because save can occure anytime.

Fixes #8321 - correctly pull Compute Resource image method from compute attributes

Fixes #844 #5725 - correct hosts count in puppetclass

Fixes #7954 - When creating a host cant is spelled wrong under partition table side note

Fixes #746 - Generate all the Host template when click on Build to avoid errors during installation

Fixes #2089 - Add network configuration to ENC

Fixes #6710 - unicode characters in url parameters

Original methods to_param defined on resources called name.parameterize
to get rid of url-unsafe characters. This function unfortunately also
stripped off unicode characters.

Changes:
- parameterization extracted into a separate module Parameterizable...

Fixes #7401 - Add support for bonds

Renames physical_device to attached_to and move the virtual device
form out of BMC.
Extends the form for Bond devices
Allow configuration of bonds in KS template
Parsing of Bond interfaces from facts
Mac address is required only for physical devices

Refs #3809 - Use parentheses in method definitions

Refs #3809 - Fix a few rubocop TODOs

Refs #3809 - Remove rubocop TODOs

Removed the following TODOs so that cops for these will run from now on:

Lint/AmbiguousOperator, DefEndAlignment, DeprecatedClassMethods
EnsureReturn, RequireParentheses, Void, BlockAlignment, EndAlignment,
UselessAccessModifier,...

fixes #7163 - on host's edit page, show the source for the value of puppet class parameters.

Fixes #7572 - remove rundeck from core

Foreman rundeck is now a plugin available in https://github.com/theforeman/foreman_host_rundeck

fixes #4386 - gem friendly_id to simplify find by id, name, label, etc

Fixes #6695: Adding two OS parameters with same name should raise an error

Fixes #6468 - Allow filtering/searching by active user

Fixes #5692 - correct counts in cached_counters

fixes #4375: provisioning no longer loops when using oVirt + compute profile

Fixes #7344 - ignore saving errors during fact parsing

Fixes #6444 - add support for virtual NICs

Extend additional interface details refs #2240

NIC facts parsing change and we create interfaces in Foreman according
to facts we recieve.

Subclasses does not define their own attributes and serialize them to
attrs hash. All BMC attributes are extracted to separate columns so it's...

Fixes #5926 - hide sensitive parameter values

User can check to hide value when creating or editing global parameter.
The value is masked by *** and is also not displayed when overriding.

Fixes #6998 - Accept native true for overwrite parameter to host API.

Fixes #6560 - Extract puppet parsing logic

Fixes #6566 - renaming a node now resets the certname on provision

If use_uuid_for_certificates is true, reuse the certname UUID value.
If false, then reset the certname if it does not match the hostname.

Fixes #215: Parameters can be saved without a value

fixes #6636, #6657, #6694 - add field length validations, extend audit field length

fixes #6430 - validate presence of location and organization for managed host if Settings are turned on

fixes #6618 - provide an indentation helper for provisioning templates

fixes #3664 - support deletion of installation media that's in use

fixes #4155 - enable host/CR (dis)association via api

fixes #6358 - Update LookupValue fqdn matchers when a host is renamed

fixes #6177 - clear host facts/reports when build=true set over API

fixes #6410 - update to deep_cloneable 2.0

[REFACTOR] refs #6229 - extract validation to a method

this enables plugins (e.g. katello) to override the validation when
requried.

fixes #5915 - Add support for Infiniband 64-bit MAC addresses

fixes #6229 - validate installation media exists for new host if pxe_build

fixes #6228 - disable provisioning method radio boxes after host is provisioned

fixes #5722: VM-based host cloning picks up existing compute attributes

fixes #5708: #nil? is now an allowed method inside of Host and Token jails

fixes #5834 - Hosts: . in the name is invalid - user is told this but the UI adds one anyway

fixes #5690 - determine host taxonomy fact based on setting value

fixes #4250 - API v2 - add compute profiles

fixes #2785 - host model clone method also copies relationships using deep_cloneable gem

fixes #5450 - add realm to params for 1.4-compatible use in templates

fixes #5444 - add param_false? host method and allow in templates

fixes #5246 - remove second host/class lookup impl so config groups are included in ENC output

fixes #4204 - add config groups feature - assign multiple config groups to a host or hostgroup

fixes #5053 - minor bug fixes to realm integration

fixes #4381: dns records are being update after changes to host when dhcp is also present