Fixes #23875 - removed old session tests

Fixes #21580 - normalize compute attributes (#4980)

Normalizes compute attributes in API show actions. For backwards
compatibility reasons this patch adds a new rabl node instead of
replacing 'vm_attrs'.

Fixes #23379 - proxy stubs on API level

Refs #23499 - pids for ported tests

fixes #23357 - Refactor Notification Drawer from patternfly-react

fixes #23573 - add pagelets for cr show page

Fixes #23609 - Port robottelo tests for classparameters

Fixes #23605 - Port robottelo tests - smart_proxy

Fixes #23597 - Port robottelo tests - combination template

Fixes #23586 - Port robottelo tests for template

Fixes #23565 - Port robottelo test for smart variables

port robottelo tests for filters

Fixes #23485 - Port robottelo tests for interfaces

Fixes #18429 - Add foreman API support for trends

Fixes #23419 - Port robottelo tests for hostgroup

Fixes #19781 - Fix Layout/LeadingCommentSpace cop

Fixes #23295 - Robottelo tests reporting (#5464)

Refs #23177 - datetime precision fixed for unattended test

Refs #23177 - id is not used for unattended order

Fixes #23350 - Port: Robotello: Minitest: Role Tier1 Tests

fixes #23335 - normalize scsi attributes in rails 5 (#5475)

Fixes #23339 - Port robottelo tests for hosts

Fixes #23254 - Utilize webmock to prevent network connection

in tests

Fixes #23252 - Speed up unattended controller tests

Splitting the tests into different contexts and only creating the hosts
needed for each context cut down runtime locally from 57s to 23s.

Fixes #23177 - unattended warning on multiple MACs

Fixes #23225 - fix vm tab js error in host page

Fixes #23132 - Port robottelo tests for bookmarks

Fixes #22855 - Add full breadcrumbs functionality

Fixes #19787 - Fix Layout/SpaceAfterComma cop

Fixes #23106 - Port robottelo tests for usergroups

Fixes #19894 - Fix Style/RedundantParentheses cop

Fixes #19839 - Fix Rails/Present cop

Fixes #23123 - Fix Rails/ActiveRecordAliases cop

Fixes #22893 - Specify taxonomies on template import (#5323)

fixes #21694 - Add consistency validation for MTU and VLAN

Fixes #23075 - Fix Rails/HttpStatus cop

Fixes #23095 - Fix mysql tests

Fixes #23095 - Port robottelo tests for subnets and parameters

Fixes #23066 - Port robottelo tests for users and user roles

Fixes #23045 - Port Robottelo PTables tests

Fixes #23004 - Port robottelo tier1 media tests

Refs #22285 - Prepare tests for strong params enforcement

- Fix broken hosts api tests
- Fix role cloning tests
- Fix ssh key controller api test
- Fix http proxies controller test
- Fix lookup key override api controller test
- Fix puppetclass controller api test...

Fixes #22236 - Adds breadcrumbs to foreman UI

Fixes #22922 - Port robottelo tier1 compute profiles tests (#5333)

Fixes #22990 - Port robottelo tier1 compute resources

Fixes #22624 - User selectable columns model + api

Adding initial bindings to user selectable columns. This model + api is
going to be used in work related Katello plugin's subscription pages.
The main intesnt of this PR is to provide a basic model where a user can...

Fixes #22979 - Port Robottelo OperatingSystems tests

Fixes #22910 - Port robottelo tier1 environment tests (#5329)

Fixes #22930 - Port robottelo Architectures tests (#5335)

Fixes #22800 - Port robottelo tier1 location tests

Fixes #15984 - Avoid escaping overridden parameters (#5126)

Fixes #15286 - New API for auth sources (#4865)

Fixes #22793 - Port robottelo tests for organization (#5295)

Fixes #22756 - Allow provisioning based on MAC address

Fixes #22779 - Calculate out of sync host via origin interval (#5221)

Fixes #22358 - add templates importing

Fixes #22721 - Rename setting to trusted_hosts

The setting trusted_puppetmaster_hosts is used to allow hosts to submit
stuff to the facts/reports API endpoint.
The name made sense a long time ago, but these days other plugins and
any user can submit stuff to this API to generate...

Fixes #22747 - vet puppetclass_id on addition

Fixes #21999,#22005 - Migrate toasts to pf-react

• Replace Alert and Toasts components with patternfly-react
• Refactor the server side flash-notification
• Allow rails-flah-notification to react-toast-notification with link

Fixes #17316 - templates feature is subnet association

Fixes #22069 - Add proxy version mismatch warning

Fixes #9868 - adding test for organization controller

fixes #22444 - do not serve templates with expired token

Refs #20800 - Move session timed out warning inline

Refs #21871 - Test resource_scope using existing tables

This patch is needed in order to run tests with plugins that pass. The
'after_run' method gets called after test rake tasks. In Jenkins,
when plugins are called with 'rake jenkins:unit jenkins:integration'...

Fixes #21871 - Fix searching by locations

Fixes #22359 - Don't rely on default taxonomy in API for any user (#5202)

Fixes #19776 - Configure Layout/FirstParameterIndentation cop

Fixes #19907 - Configure Style/TernaryParentheses cop

Fixes #19838 - Fix Rails/PluralizationGrammar cop

Fixes #11389 - Remove API v1

API v1 has been deprecated since Foreman 1.9 - over 2 years ago.
This is more then enough time for anyone needing to migrate to v2.
Even though the original issue requests extraction to a plugin, I do not
see any point in investing the time and effort to maintain a long...

Refs #22164 - use cheaper FactoryBot methods

• Refs #22164 - FactoryBot.build -> FactoryBot.build_stubbed

• Refs #22164 - FactoryBot.create -> FactoryBot.build

in
- test/unit/*
- test/models/shared/taxonomies_base_test.rb
- test/controllers/hosts_controller_test.rb

Fixes #5790 - Add compute resource to hostgroup (#4593)

Fixes #19771 - Fix Layout/EmptyLineAfterMagicComment cop

Fixes #19769 - Fix Layout/CommentIndentation cop

Fixes #19780 - fix Layout/IndentationWidth cop

fixes #20839 - new react implementation for bookmarks dropdown

Fixes #21851 - Remove deprecations for 1.17

Fixes #21760 - Fix tests on Rails 5.1

Fixes #21343 - support multiple orgs supported for non-admin users

• Fixes #21343 - support multiple orgs supported for non-admins

This adds a full support for taxonomies in API for non-admin users. It
fixes the issue with dirty associations module that only track _ids...

fixes #21956 - apply compute profile only when needed

Fixes #21944 - HttpProxy - whitelist taxonomix params

Fixes #21102 - Replace 'xhr' in tests with keyword argument

Fixes #21099 - Replace redirect_to :back with redirect_back

Some instances of process_success/error with :back as a redirect also
need changing, and the redirect_back_or_to helper should be deprecated
and replaced throughout with redirect_back too.

Fixes #21098 - Use positional args in functional test requests

Fixes #4238 - Prevent login brute forcing

After 30 failed attempts from the same ip, login will be blocked for 5
minutes from that ip.

Fixes #21776 - Improved fact importing to deal with names

Now the list of fact names will be calculated beforehand and saved
to the database. It will also consider that the name could be added
from other thread.

Fixes #21353 - users can edit login if they have permissions

fixes #21658 - add pagelet extension points to hostgroup form

Fixes #21503 - Import puppet classes when organzations changed

fixes #21579 - pagelets for host show

Fixes #20204 - returns all hosts for unassigned hostgroup

Fixes #15402 - Moved puppet to separate api controller

Fixes #21424 - use factory_bot_rails

Fixes #16835 - Allow implicit search with org_id

Previously, any resource with many taxonomies would fail when using
implicit search when passing organization_id parameter to the api. This
is due to scoped_search incorrectly adding the taxonomy table to search...

Fixes #21442 - Load puppetclass params on new host form

This was caused by a Rails 5 change in ActionView that skips blank
data attributes [1] causing the JS code used to serialize the form²
to send `undefined` instead of `null` which was expected previously....

Fixes #17992, #18103 - Improve external usergroup errors

When one submit an user group with external user groups, and this
doesn't work for whatever reason, like:

Net::LDAP::Error - No route to host - connect(2)
LdapFluff::Generic::UnauthenticatedException...

fixes #21394 - user login with access token api

Fixes #21119 - set taxonomies in API

With this we correctly set the default taxonomy for non-admin users
in API calls. Admins are not touched at all, their context remains
"any context" for API calls. This also refactors various places
where tried to set the right taxonomy and combines them into single...

Fixes #20541 - Include nested facts in CSV export