Project

General

Profile

« Previous | Next » 

Revision 85a97146

Added by Dominic Cleal about 8 years ago

fixes #13244 - update Rails to 4.2.6

- Add responders gem to support class-level respond_to usage
- http://edgeguides.rubyonrails.org/4_2_release_notes.html#respond-with-class-level-respond-to
- Replace foreigner with native Rails 4.2 FK support
- uses a patch from Rails 5 to support Foreigner's
`foreign_key_exists?` helper for full compatibility
- `foreign_keys` should be avoided in favour of the higher level
methods as it throws a NotImplementedError on sqlite3
- Update DB adapter versions to match ActiveRecord
- Enable exceptions from after_commit handlers to detect more errors
- Change deprecated application config settings
- Remove test:lib chaining on rake test task
- 4.2 runs lib tasks automatically now, as test:run is redefined
to all _test files within test/ rather than units+functionals.
The task is still needed for the jenkins:* tasks.
- Fix deprecation of mailer #deliver method, change to #deliver_now
- Change CSRF test to use generated, not static tokens
- 4.2 changes CSRF tokens to be different on every request and
validated against the session, so use its generator to test the
controller behaviour instead of hardcoding tokens.
- Change test execution order to random

View differences:

app/models/mail_notifications/mail_notification.rb
if args.last.is_a?(Hash) && args.last.has_key?(:users)
options = args.pop
options.delete(:users).each do |user|
mailer.constantize.send(method, *args, options.merge(:user => user)).deliver
mailer.constantize.send(method, *args, options.merge(:user => user)).deliver_now
end
else
mailer.constantize.send(method, *args).deliver
mailer.constantize.send(method, *args).deliver_now
end
end
end

Also available in: Unified diff