Revision d6c08a7a
Added by Daniel Lobato Garcia over 8 years ago
| test/unit/environment_test.rb | ||
|---|---|---|
|
end
|
||
|
end
|
||
|
|
||
|
test "should have name" do
|
||
|
env = Environment.new
|
||
|
refute env.valid?
|
||
|
end
|
||
|
|
||
|
test "name should be unique" do
|
||
|
as_admin do
|
||
|
env = Environment.create :name => "foo"
|
||
|
env2 = Environment.new :name => env.name
|
||
|
refute env2.valid?
|
||
|
end
|
||
|
end
|
||
|
should validate_presence_of(:name)
|
||
|
should validate_uniqueness_of(:name)
|
||
|
should have_many(:provisioning_templates).through(:template_combinations)
|
||
|
should have_many(:puppetclasses).through(:environment_classes)
|
||
|
should have_many(:trends).class_name('ForemanTrend')
|
||
|
should allow_mass_assignment_of(:name)
|
||
|
|
||
|
test "to_label should print name" do
|
||
|
env = Environment.new :name => "foo"
|
||
| ... | ... | |
|
end
|
||
|
end
|
||
|
|
||
|
test "Should create environment with the name 'new'" do
|
||
|
environment = Environment.new(:name => 'new')
|
||
|
assert environment.valid?
|
||
|
test 'should create environment with the name "new"' do
|
||
|
assert FactoryGirl.build(:environment, :name => 'new').valid?
|
||
|
end
|
||
|
end
|
||
Also available in: Unified diff
Fixes #11618 - Replace validation tests by shoulda-matchers
A good chunk of our unit tests are testing whether a validation is
working or not by testing it actively. For the validations we've
added ourselves I would say it's fine. However for validations that
come from the Rails framework, we're essentially testing their job.
Instead of testing (for instance) validates(:name, :uniqueness =>
true) by creating two objects and verifying the second one won't
save (these tests are already done at the framework level), we
should simply test we're including validations in our models.
The well-maintained gem shoulda-matchers provide easy functions to
check we're including such validations, and other helpers we can
use to refactor our tests further and not test Rails functionality
twice.