Project

General

Profile

« Previous | Next » 

Revision f8d94608

Added by Amos Benari over 11 years ago

  • ID f8d946082e58b60213a27ded3e1e5f5373d976de

fixes #832 - adds parameterized class support

Credits:
This patch is based on the original work of Olivier Favre
<> many many thanks!

This patch adds the following features
  • import class parameters, and try to understand their types
  • support a complex matrix of environments, puppet classes and their
    signature - each class can have a different set of parameters per environment.
  • adds an ignore yaml file 'config/ignored_environments.yml.sample' file were
    users can add regexp or class names that the importer should ignore.
    common usage case for this is classes such as ::config, ::install etc.
  • introduce a new type of smart variable - parameterized.
  • adds complex data types to smart vars, arrays, hashes, json, yaml etc are all supported now.

in order to use the new ENC format for puppet 2.6.5+ you should enable the
Parametrized_Classes_in_ENC and Enable_Smart_Variables_in_ENC within Foreman Settings

This is the initial patch just to get param classes support in, follow-up patches
would include a better UI and the relevant UI updates to host edit page etc.

Signed-off-by: Ohad Levy <>

View differences:

test/functional/lookup_keys_controller_test.rb
end
test "should get edit" do
get :edit, {:id => lookup_keys(:one).to_param, :puppetclass_id => puppetclasses(:one).id}, set_session_user
get :edit, {:id => lookup_keys(:one).to_param}, set_session_user
assert_response :success
end
test "should update lookup_keys" do
put :update, {:id => lookup_keys(:one).to_param, :puppetclass_id => puppetclasses(:one).id, :lookup_key => { :key => "test that" }}, set_session_user
assert_redirected_to lookup_keys_path
put :update, {:id => lookup_keys(:one).to_param, :lookup_key => { :description => "test that" }}, set_session_user
assert_response :success
end
test "should destroy lookup_keys" do
assert_difference('LookupKey.count', -1) do
delete :destroy, {:id => lookup_keys(:one).to_param}, set_session_user
end
assert_redirected_to lookup_keys_path
end

Also available in: Unified diff