Project

General

Profile

« Previous | Next » 

Revision 9a23ee14

Added by Stephen Benjamin almost 8 years ago

fixes #15556 - move some params to advanced (#264)

This reduces the amount of default help text and confusing options for
plugins. This is especially confusing for 'enabled' as there are 2
options:
```
--[no-]enable-foreman-proxy-plugin-remote-execution-ssh
--foreman-proxy-plugin-remote-execution-ssh-enabled
```
The former REALLY enables the plugin, the latter is only controlling
the value in the .yml configuration which has a sane default value.
We should hide this, and some of the other options like `listen_on`,
`group`, etc which probably don't need changing ever.

View differences:

manifests/plugin/chef.pp
#
# === Parameters:
#
# $group:: group owner of the configuration file
#
# $version:: plugin package version, it's passed to ensure parameter of package resource
# can be set to specific version number, 'latest', 'present' etc.
#
# $enabled:: enables/disables the plugin
#
# $listen_on:: Proxy feature listens on http, https, or both
#
# $server_url:: chef server url
#
# $client_name:: chef client name used for authentication of other client requests
......
# contains certificate and related private key if the certificate
# is not globally trusted
#
# === Advanced parameters:
#
# $enabled:: enables/disables the plugin
#
# $group:: group owner of the configuration file
#
# $listen_on:: Proxy feature listens on http, https, or both
#
# $version:: plugin package version, it's passed to ensure parameter of package resource
# can be set to specific version number, 'latest', 'present' etc.
#
class foreman_proxy::plugin::chef (
$enabled = $::foreman_proxy::plugin::chef::params::enabled,
$listen_on = $::foreman_proxy::plugin::chef::params::listen_on,

Also available in: Unified diff