Foreman » Smart Proxy

Fixes #37450 - start free_ips service for native ms dhcp

Fixes #37413 - Let the kernel assign a TCP port in tests

This binds on port 0, which lets the kernel decide which port to use.
The port is then read back from the listener. Because the kernel knows
which ports it's allowed to bind to, it removes the risk of a failure...

Fixes #37355 - Explicitly query for IPv4 address in omapi code

The omapi API is IPv4-only so the DNS lookup should also only ask for
IPv4 addresses. Otherwise it may return an IPv6 address which ip2hex
can't deal with.

Fixes #37147 - Pass --fail option to curl

This prevents curl from writing out error pages, for example when the
URL returns a HTTP 404.

It still doesn't return any error to Foreman since the TFTP
/fetch_boot_file only starts a thread and there's no way to monitor it....

Bump develop to 3.11.0-develop

build on rhel-9

use yum.tfm.o

build on rhel-8

Bump develop to 3.10.0-develop

Fixes #36899 - Add Dependabot Configuration

Fixes #36890 - Use PrivateTmp in systemd service

add packit

Fixes #34163 - Allow clearing the log buffer

In testing it can be useful to reset the log buffer. This is not
intended to be used as a public API but tests can use:

Proxy::LogBuffer::Buffer.instance.send(:clear)

Refs #34163 - Introduce SmartProxyRootApiTestCase

This class provides the common infra for the root API integration test.

Refs #36779 - Fix Style/SlicingWithRange cop

Fixes #36779 - Set minimum Ruby version to 2.7

Fix Rubocop Rake/Desc

Enable rubocop-rake plugin

Fix Rubocop Style/RedundantCondition

Disable Style/RedundantCondition

Fix Rubocop Style/SafeNavigation

Fix Rubocop Lint/RedundantStringCoercion

Update RuboCop version to 1.56.0

Bumped the RuboCop version from 1.28.0 to 1.56.0 to ensure the
project benefits from the latest improvements, bug fixes, and
code analysis features provided by the updated RuboCop release.

Add additional cops to rubocop-todo.yaml

Added additional RuboCop cops and updated .rubocop_todo.yml
to address various code quality issues in the smart-proxy project.
The changes help improve code consistency.

Bump develop to 3.9.0-develop

Bump develop to 3.8.0-develop

refs #36243 - Templates - Return Foreman's API status code

Bugfixes and improvements

refs 70073c07e991cbe85a332a00e90d4196d8cbcaaf

Fixes #36243 - Templates - Return Foreman's API status code instead of 500

Fix typo / fix link markup

Fixes #36209 - tftp initrd/vmlinux generation: curl malformed

PR #856 was fixing invalid curl --time-cont condition,
but it actually break it and now files are not downloaded at all.

This reverts commit fba49ab1eb9bbe383572575309558ff628f5de60.

Fixes #36138 - Invalid syntax for curl --time-cond

According to Curl man page, syntax for --time-cond attribute
should be "--time-cond file <path>", not "--time-cond <path>".

This can cause issues with outdated vmlinuz and initrd.im files,
once the files are downloaded, they are never replaced with never versions....

Fixes #35921 - Disable access logging for https endpoint

Previously, access logging was enabled for https endpoint, but not for
the http one. This commit settles things on no access logging for both.

Refs #35921 - Unify use of common app settings

Common options were previously duplicated between http and https
application settings.

Bump develop to 3.7.0-develop

Fixes #35979 - dnscmd nil string error

Fixes #35920 - Mention JOURNAL as valid log_file option

in example settings

Bump develop to 3.5.0-develop

Fixes #35639 - registration_url setting for Registration module

RFC: https://community.theforeman.org/t/rfc-host-registration-and-load-balancers/30462
Foreman: https://projects.theforeman.org/issues/35626
Katello: https://projects.theforeman.org/issues/35627

Refs #35639 - Add OptionalUrl validator

Update rubocop to 0.89

Fixes #35510 - Depend on webrick for Ruby 3

This has always been a dependency, but Ruby 3 has dropped the code. It's
now a regular gem.

It is set in the gemspec since that allows plugins to also benefit from
it. That does mean that it's also required on older Ruby versions and...

Fixes #31118 - Remove daemonize support

Currently Smart Proxy is able to daemonize and manage a pid file.
However, in the common deployments under systemd and Windows this isn't
actually used. There are also other solutions out there to manage it
externally if it's needed....

Fixes #35507 - Pin sinatra to 2.x

Previously in CI it was pulling in version 1.0 but that's ancient and
doesn't work.

Fixes #35468 - Verify boolean settings in modules

Since debffb85b60a5dfc2d5347075d8f2089573f289f it's possible to validate
boolean settings. Validating settings makes it harder to misconfigure
modules.

Fixes #35467 - Use rackup_path helper in registration

Since 88fbc8e67d665e2c3b19acb53b31ff30acf078b7 there is a rackup_path
helper that's equivalent to calling http_rackup_path and
https_rackup_path with the same arguments.

Fixes #33881 - Remove deprecated plugin methods

Version 1.12.0 (342eeda9a14422a30f08f3ce6539577ea6a740c8) added these
methods, but with a note that they will be removed.

Refs #33881 - Remove unused Proxy::ProviderFactory

Unused since 1.11.0 (42b958156808eb2a16bd895863b196fca8f2977d).

Refs #33881 - Remove Proxy::Dns::DependencyInjection::Dependencies

Version 1.13.0 (69afd3426cece83821d9bdb16be426a082b68e42) deprecated
this class.

Refs #33881 - Drop deprecated HttpDownload parameters

Version 3.1.0 (3d87c6feaa8caaf9b8c040f96061c3b8c33a39ef) deprecated
these parameters.

Signed-off-by: Lukas Zapletal <lzap+git@redhat.com>

Refs #33881 - Drop deprecated DNS common methods

Version 1.23.0 (ee1dcd16bdba277294cb9c744b667f911e1ea7c7) deprecated
these methods.

Refs #33881 - Drop deprecated methods in DHCP API

These methods were deprecated c7aa35f0b18090e7e7d1b06493449972b6de37bc
(part of 1.15.0).

Fixes #35384 - Add missing require 'timeout'

This explicitly requires timeout rather than depending on it implicitly.

Fixes: aa25357d4404908d5e5707e767ecd798b754d7d1

Update develop to 3.5.0-develop

Fixes #35185 - Stub provider check in BmcTest

Rubyipmi checks if ipmitool is installed, but never actually uses it.
Stubbing the presence check makes testing easier for developers.

Fixes #35184 - Drop puppetca_puppet_cert provider

Currently for Puppet 6.0 or higher the Puppetserver REST API is used.
Puppet 5 is EOL so this can be dropped. Older versions (dating back to
Puppet 4) had an incomplete API, but core methods do work. Just the...

Fixes #35183 - Correctly call Timeout.timeout()

At least in Ruby 3.1 calling timeout() as a global method is no longer
allowed and Timetout.timeout is the correct way of calling it.

Bump develop to 3.4.0-develop (#833)

Fixes #34844 - load SSL keys using OpenSSL::PKey.read

This allows using non-RSA keys as PKey.read can figure out the type of key automatically

Fixes #34613 - Verify SSL CA file is readable on startup

Fixes #34624 - Set MALLOC_ARENA_MAX to counter memory bloating

Fixes #34589 - Remove duplicate rsec gem definition

This fixes the duplicate gem warning that bundler generates.

Fixes #34566 - Refactor validate_ip to use a case statement

This has the same result, but is slightly more easier to follow and
potentially slightly more efficient.

Fixes #34563 - Drop rdoc from test dependencies

By allowing the Rakefile to gracefully handle rdoc's absense it can be
dropped from the test dependencies.

Refs #34563 - Allow comments for Lint/SuppressedException

Refs #34563 - Fix rdoc task to refer to README.md

In c08eb9a80d33655279ad4cc6039f0299ccb14e3b this file was renamed from
README to README.md, but this reference wasn't updated.

Fixes: c08eb9a80d33655279ad4cc6039f0299ccb14e3b

Fixes #34564 - Drop single_test gem dependency

This gem is unmaintained and doesn't appear to be used.

It was added in 1112ca8ae2c96a50f32322760c968ffdd9354eeb but nothing
else refers to it.

Fixes #27088 - Handle capabilities for uninitialized plugins

Signed-off-by: Lukas Zapletal <lzap+git@redhat.com>

Update minimum Puppet version in README

Fixes: 7e7015aba068db541bd4f4cf1856bf69ebbe2953

Fixes #34162 - Allow calling load_test_settings without settings

This allows loading only the default settings:

Proxy::MyPlugin::Plugin.load_test_settings

Or

Proxy::MyPlugin::Plugin.load_test_settings()

Previously this had to be written as

Proxy::MyPlugin::Plugin.load_test_settings({})

Fixes #34359 - fix DHCP IP validation arguments tests

Bump develop to 3.3.0-develop

Fixes #34164 - Add enum plugin validator

This allows using:

validate :setting, enum: %w[first second]

Refs #34226 - dnscmd nil string error

Signed-off-by: Lukas Zapletal <lzap+git@redhat.com>

Refs #34226 - dnscmd nil string error

Fixes #34226 - dnscmd nil string error

Fixes #34141 - Make validators modern Ruby compatible

In old Ruby versions a hash was pushed as the last argument but in
modern Ruby there is first class support for this via kwargs. This
worked if a single argument was provided but if they were combined it...

Fixes #33772 - improve DHCP parser binding test

Signed-off-by: Lukas Zapletal <lzap+git@redhat.com>

Fixes #33915 - Bump develop to 3.2.0-develop

Refs #2412 - use curl for downloads

Fixes #33756 - require 'templates' for 'registration' module

fixes #18069 - Add ip/mac Addr. validations (DHCP)

fixes #4026 - fixes #4026 secure Windows command execution

Fixes #33520 - Silence bundler

Fixes #33452 - disable SSL client renegotiation

Fixes #32607 - drop host from x-forwarded-for

Fixes #2412 - don't continue wget downloads

Bump version to 3.1.0-develop

Point to Libera instead of Freenode

Drop badges from README

The build status points to a wrong build and nobody noticed. The IRC
channel also points to the old channel.

fixes #18936 - Check server certs in the TFTP module

Bump version to 3.0-develop

Fixes #32164 - skip IPv6 link local addresses in FQDN lookups

bump version to 2.6-develop

Fixes #32288 - verify FreeIPA CA by default and new setting

Bump version to 2.5.0-develop

Fixes #31537 - Expose BMC providers as capabilities

Currently the BMC module exposes an API endpoint /providers/installed
but this can also be provided as capabilities or settings. This allows
Foreman to determine up front if a proxy is even a valid choice without...

Refs #30906 - correct redfish SSL verify setting

Fixes #31303 - Drop deprecated disable_plugin methods

342eeda9a14422a30f08f3ce6539577ea6a740c8 (included in 1.12) deprecated
these methods. It's safe to remove them now.

Bump version to 2.4-develop

Refs #30677 - support also urlencoded data

The default registration template in Foreman started to send the data in
urlencoded form instead of a JSON, as of https://projects.theforeman.org/issues/31043

In order to support that, we need to remove nested parameters from query,...