Bug #12391: Discovery breaks ignore_puppet_facts_for_provisioning global setting - Discovery - Foreman

Custom queries

All issues closed in the last 3 weeks
Discovery by votes
Easy and Trivial Issues
Good first issues - Foreman core
Mine
My issues closed in the last 3 weeks
Untriaged and opened in the past two weeks

Actions

Copy link

Bug #12391

closed

Discovery breaks ignore_puppet_facts_for_provisioning global setting

Added by Matt Jarvis over 8 years ago. Updated over 8 years ago.

Status:

Closed

Priority:

High

Assignee:

Lukas Zapletal

Category:

Discovery plugin

Difficulty:

Triaged:

Bugzilla link:

1313675

Pull request:

https://github.com/theforeman/foreman_discovery/pull/234

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description

For the last couple of versions of Foreman, the disabling of auto-creation of network interfaces has stopped working. This used to be disabled by setting ignore puppet facts for provisioning to True, which we have set, but we still get network interfaces being created. This is a big problem for us on OpenStack compute nodes, which have many virtual interfaces created, and eventually this ends up with timeouts in puppet and Foreman as there can be many hundreds of interfaces for a host, which also stops us being able to edit the host. The only fix is to delete them all via the API.

Related issues 4 (0 open — 4 closed)

Related to Foreman - Feature #9104: Disable auto network interfaces	Closed	Marek Hulán	01/25/2015	Actions
Related to Foreman - Feature #11972: Implement regex for option ignore_puppet_facts_for_provisioning	Closed	Marek Hulán	09/26/2015	Actions
Related to Foreman - Bug #11047: Interfaces are imported even though ignore_puppet_facts_for_provisioning is set to true	Resolved		07/08/2015	Actions
Related to Discovery - Bug #14643: Migration broken with discovered hosts	Closed	Lukas Zapletal	04/14/2016	Actions

Issue # Delay: days Cancel

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Dominic Cleal over 8 years ago

Related to Feature #9104: Disable auto network interfaces added

Actions

Copy link

Updated by Dominic Cleal over 8 years ago

Category set to Importers

Actions

Copy link

Updated by Matt Jarvis over 8 years ago

In poking around in the facts importer in the codebase I spotted this commit https://github.com/theforeman/foreman/commit/379de99adbde93349824d4516b95079bfd970e90
which would partially solve the problem for us. In the meantime I've locally patched our copy to exclude the qbr|qvo|ovs|tap etc interfaces that OpenStack uses which seems to be stopping them being created.

Actions

Copy link

Updated by Brandon Weeks over 8 years ago

+1 I can reproduce this.

Actions

Copy link

Updated by Brandon Weeks over 8 years ago

+1 I can reproduce this.

Both ignore_puppet_facts_for_provisioning and #11972 are happening "too late." The fact_name table spam is unaffected by their use. ignore_puppet_facts_for_provisioning doesn't even seem to prevent the nics table entries from being created.

Actions

Copy link

Updated by Brandon Weeks over 8 years ago

Brandon Weeks wrote:

+1 I can reproduce this.

Both ignore_puppet_facts_for_provisioning and #11972 are happening "too late." The fact_name table spam is unaffected by their use. ignore_puppet_facts_for_provisioning doesn't even seem to prevent the nics table entries from being created.

https://github.com/theforeman/foreman_discovery/blob/develop/app/lib/puppet_fact_parser_extensions.rb#L25

Well that's definitely the cause.

Actions

Copy link

Updated by Dominic Cleal over 8 years ago

Project changed from Foreman to Discovery
Category changed from Importers to Discovery plugin

Ouch, that's pretty special. I'll punt this to the Discovery plugin for now then, hopefully Matt will confirm that he's got that installed too.

Actions

Copy link

Updated by Matt Jarvis over 8 years ago

Yes, we've got the Discovery plugin installed.

Actions

Copy link

Updated by Brandon Weeks over 8 years ago

Related to Feature #11972: Implement regex for option ignore_puppet_facts_for_provisioning added

Actions

Copy link

#10

Updated by Brandon Weeks over 8 years ago

Thank for spotting that commit Matt, it has been a huge help for us. I've proposed backporting in #11972.

Actions

Copy link

#11

Updated by Dominic Cleal over 8 years ago

Related to Bug #11047: Interfaces are imported even though ignore_puppet_facts_for_provisioning is set to true added

Actions

Copy link

#12

Updated by Lukas Zapletal over 8 years ago

Subject changed from Disable auto creation of network interfaces not working to Discovery breaks ignore_puppet_facts_for_provisioning global setting
Status changed from New to Assigned
Assignee set to Lukas Zapletal

Yeah a bummer, did not realize this actually affect everything.

Actions

Copy link

#13