Feature #2307: Include ::daemon or ::cron based on param value - Installer - Foreman

Actions

Copy link

Feature #2307

closed

Include ::daemon or ::cron based on param value

Added by Gavin Williams about 11 years ago. Updated about 8 years ago.

Status:

Resolved

Priority:

Normal

Assignee:

Category:

Target version:

Difficulty:

Triaged:

Bugzilla link:

Pull request:

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description

Currently when attempting to install and configure the Puppet agent, it is not configured to run either as a daemon or a cron job.

Could add a param such as 'runmode', which could either be 'daemon' or 'cron'.
This can then include the relevant classes based upon it's value.

Actions

Copy link

Updated by Gavin Williams about 11 years ago

Have added some rough code to a local branch: https://github.com/fatmcgav/puppet-puppet/commit/45211baf848d241049cd5793e000cd39c5c1b6dc

Comments welcome before submitting as a pull request.

Actions

Copy link

Updated by Dominic Cleal about 11 years ago

I like the look of that. It'd begin to fix an issue I've hit before with the service not being set up (we're also missing enable => true on the service resource). The only small difficulty will be if people today are including both the puppet and puppet::cron classes to get cron-based puppet, but I think it's worth ignoring for the goal of parameterising it.

Actions

Copy link

Updated by Greg Sutcliffe about 11 years ago

Dominic Cleal wrote:

I like the look of that. It'd begin to fix an issue I've hit before with the service not being set up (we're also missing enable => true on the service resource). The only small difficulty will be if people today are including both the puppet and puppet::cron classes to get cron-based puppet, but I think it's worth ignoring for the goal of parameterising it.

Do it as an include, then it won't conflict with existing setups, since include can be used multiple times.

Actions

Copy link

Updated by Gavin Williams about 11 years ago

Greg Sutcliffe wrote:

Dominic Cleal wrote:

I like the look of that. It'd begin to fix an issue I've hit before with the service not being set up (we're also missing enable => true on the service resource). The only small difficulty will be if people today are including both the puppet and puppet::cron classes to get cron-based puppet, but I think it's worth ignoring for the goal of parameterising it.

Do it as an include, then it won't conflict with existing setups, since include can be used multiple times.

Makes sense... Will convert to use include and submit as a PR :)

Actions

Copy link