Feature #2307
closed
Include ::daemon or ::cron based on param value
Added by Gavin Williams about 11 years ago.
Updated about 8 years ago.
Description
Currently when attempting to install and configure the Puppet agent, it is not configured to run either as a daemon or a cron job.
Could add a param such as 'runmode', which could either be 'daemon' or 'cron'.
This can then include the relevant classes based upon it's value.
I like the look of that. It'd begin to fix an issue I've hit before with the service not being set up (we're also missing enable => true on the service resource). The only small difficulty will be if people today are including both the puppet and puppet::cron classes to get cron-based puppet, but I think it's worth ignoring for the goal of parameterising it.
Dominic Cleal wrote:
I like the look of that. It'd begin to fix an issue I've hit before with the service not being set up (we're also missing enable => true on the service resource). The only small difficulty will be if people today are including both the puppet and puppet::cron classes to get cron-based puppet, but I think it's worth ignoring for the goal of parameterising it.
Do it as an include, then it won't conflict with existing setups, since include can be used multiple times.
Greg Sutcliffe wrote:
Dominic Cleal wrote:
I like the look of that. It'd begin to fix an issue I've hit before with the service not being set up (we're also missing enable => true on the service resource). The only small difficulty will be if people today are including both the puppet and puppet::cron classes to get cron-based puppet, but I think it's worth ignoring for the goal of parameterising it.
Do it as an include, then it won't conflict with existing setups, since include can be used multiple times.
Makes sense... Will convert to use include and submit as a PR :)
- Status changed from New to Resolved
this got merged and since then extended in theforeman-puppet
Also available in: Atom
PDF
Updated by 
Updated by 
Updated by 
Updated by Anonymous