Project

General

Profile

Actions

Bug #36293

closed

Awk/grep should be more strict

Added by Et7f3 please_edit_me about 1 year ago. Updated 9 months ago.

Status:
Closed
Priority:
Normal
Category:
Unattended installations
Target version:
-
Difficulty:
easy
Triaged:
Yes
Fixed in Releases:
Found in Releases:

Description

When I wanted to debug a template I forgot to type https://github.com/theforeman/foreman/blob/3.3-stable/app/views/unattended/provisioning_templates/registration/global_registration.erb#L15 (running each command step by step)

And I got a issue that third word isn't the UUID https://github.com/theforeman/foreman/blob/9962f72c635838ced1da86a7e818e2c431c3853e/app/views/unattended/provisioning_templates/registration/global_registration.erb#L118

If we want to match a UUID we should match a UUID not something hazardous like third word. It will be more resistent to change of output.

I don't have other example of stricter command might be needed but would happy to fix them.

Actions

Also available in: Atom PDF