Joseph Magen wrote:

Is this still a bug if the template is not designed for host group-based provisioning?

Yes, it's our template.

I assume we should generated a better error message?

Not really, just fix the template.

Dominic Cleal wrote:

Not really, just fix the template.

• tokens
• realms

Ohad Levy wrote:

Dominic Cleal wrote:

Not really, just fix the template.

wont this add noise to the new template? for example, the following things will never work (maybe missed a couple):

• tokens
• realms

Indeed, what are you suggesting?

Dominic Cleal wrote:

Ohad Levy wrote:

Dominic Cleal wrote:

Not really, just fix the template.

wont this add noise to the new template? for example, the following things will never work (maybe missed a couple):

• tokens
• realms

Indeed, what are you suggesting?

1. add checks if hostgroup or host provisioning to every code/snppet (realms, tokens, foreman_url)
2. add a new template type for hostgroup based provisioning
3. break down to more snippets, so the option above is a bit less painful to maintain

any other option?

I prefer (1), plus (3) if that makes it easier. I don't think the changes required are too extensive.

The solution in the above PR is to create a new helper called "host_provision" which will be true in non-hostgroup provisioning. As Ohad mentioned above, this takes care of the two issues - relams and tokens.

There is an additional issue in the puppet.conf snippet which calls `certname`, so I've got a check in there - for hostgroup-based provisioning, it'll replace it with $HOSTNAME, so if the hostname is set then we'll configure it correctly.

That seems to get things up and going for me.

Note these templates will only be compatible with 1.5 and 1.6.

I don't think so, just #6861 had a bugzilla. I'd just let this whole thing die and tell HG provisioning users to write their own KS.