Refs #22058 - refresh rubocop config and apply autofixes

Fixes #23857 - Fix Performance/InefficientHashSearch cop

Fixes #23769 - consistency in docs for foreman/katello

Fixes #23426 - support default flag in templates import

Fixes #18429 - Add foreman API support for trends

Fixes #19781 - Fix Layout/LeadingCommentSpace cop

Fixes #19787 - Fix Layout/SpaceAfterComma cop

Fixes #23081 - Fix Style/SafeNavigation cop

Fixes #19839 - Fix Rails/Present cop

Fixes #22331 - Fix Rails/Presence cop

Fixes #23123 - Fix Rails/ActiveRecordAliases cop

Fixes #23067 - expose option to use oVirt APIv4

Also handle v4 certificate error and v3 path migration

Fixes #22893 - Specify taxonomies on template import (#5323)

fixes #21694 - Add MTU to subnet and interface API

Fixes #23079 - Fix Naming/HeredocDelimiterCase cop

Refs #22285 - Prepare tests for strong params enforcement

- Fix broken hosts api tests
- Fix role cloning tests
- Fix ssh key controller api test
- Fix http proxies controller test
- Fix lookup key override api controller test
- Fix puppetclass controller api test...

Refs #22285 - Correct parameter filtering for strong params

- Allow $resource_id param on parameters controller
- Permit user_id on access token controller
- Allow params in templete combination controller
Allows `config_template_id` and `:provisioning_template_id`...

Fixes #23046 - gateway parameter for subnet corrected

Fixes #22624 - User selectable columns model + api

Adding initial bindings to user selectable columns. This model + api is
going to be used in work related Katello plugin's subscription pages.
The main intesnt of this PR is to provide a basic model where a user can...

Fixes #22869 - support template locking on import

Fixes #15286 - New API for auth sources (#4865)

Fixes #22358 - add templates importing

Fixes #22753 - add apipie validator for multiple allowed types

Fixes #22747 - vet puppetclass_id on addition

Fixes #22403 - every API endpoint can set current context

Fixes #22557 - use correct type for 'provision_method' param

Fixes #7451 - Review whitespace in extracted strings

Fixes #22424 - Update Apipie doc for hostgroup

Fixes #17964 - Add list of search fields in api docs (#4735)

Fixes #21871 - Fix searching by locations

Fixes #19889 - Fix Style/PerlBackrefs cop

Fixes #21317 - graceful handling of VM association error

Instead of immediate failure, just log the issue and proceed with the
import.

Fixes #19907 - Configure Style/TernaryParentheses cop

Fixes #19871 - Fix Style/MethodDefParentheses cop

Fixes #19877 - Fix Style/NegatedIf cop

Fixes #19895 - Fix Style/RedundantReturn cop

Fixes #11389 - Remove API v1

API v1 has been deprecated since Foreman 1.9 - over 2 years ago.
This is more then enough time for anyone needing to migrate to v2.
Even though the original issue requests extraction to a plugin, I do not
see any point in investing the time and effort to maintain a long...

Fixes #21760 - Fix tests on Rails 5.1

Fixes #21343 - support multiple orgs supported for non-admin users

• Fixes #21343 - support multiple orgs supported for non-admins

This adds a full support for taxonomies in API for non-admin users. It
fixes the issue with dirty associations module that only track _ids...

Fixes #19772, #19773, #19774 - Fix some empty line cops

fixes #21956 - apply compute profile only when needed

Fixes #4238 - Prevent login brute forcing

After 30 failed attempts from the same ip, login will be blocked for 5
minutes from that ip.

Fixes #21682 - Add Domain to Compute Resource API (OpenStack)

The Domain field was added to the Compute Resources table in #12054 as
part of the Openstack v3 support. This field needs to appear in the
APIdoc to be able to use it and in the RABL to read it.

Fixes #21502 - Disable editing users in group with EUG (#4962)

Adding Users to User Groups with External User Groups does not
work. Currently the only feedback the user gets is that Users get
automatically removed after the form is submitted - no warning or...

Fixes #21611 - Improve *_name lookup speed

Fixes #20204 - returns all hosts for unassigned hostgroup

Fixes #15402 - Moved puppet to separate api controller

fixes #21394 - user login with access token api

Fixes #21119 - set taxonomies in API

With this we correctly set the default taxonomy for non-admin users
in API calls. Admins are not touched at all, their context remains
"any context" for API calls. This also refactors various places
where tried to set the right taxonomy and combines them into single...

Fixes #12216 - support http proxies for compute resources

Fixes #21299 - Make user_id required

user_id is part of the resource URL and needs to be mandatory.

Fixes #21250 - Prevent double render in not_found

Fixes #21037 - use Host::Base as auditable_type

Otherwise, we are hitting "Invalid single-table inheritance type:
Host::Discovered is not a subclass of Host::Managed" when converting the
host from discovered to managed.

Fixes #15409 - Separated puppet facts from core

Fixes #20952 - Replace AC::Parameters Hash methods

Replaces any methods that used to be from Hash with the more limited
ActionController::Parameters API.

Fixes #20966 - Added fast return to host power api

If the host does not support power actions (no BMC and the VM
does not support it - return `unprocessable_entity` and exit with
a message.

Fixes #20487 - Add rebuild_config to hostgroups API

Fixes #10726 - NIC types are immutable

Fixes #20986 - wrongly documented :user_id in ssh_keys#create

Fixes #20951 - Replace render :text with :plain

Fixes #20913 - add missing role_ids to user API

Fixes #20516 - GET hosts API displays owner_name attribute

Fixes #20500 - Allow GET /api/hostgroups to include parameters

Add include Array parameter to GET /api/hostgroups v2 that will
optionally include a hostgroup's parameters when the include parameter
contains 'parameters'.

Fixes #20763 - Reword "Create SSH key" to "Add SSH key"

Fixes #20553 - br tag now renders to new line

Refs #17525 - verify domain dns id also on update

Fixes #16112 - support for netgroups in LDAP auth source

Fixes #20212 - create and update host actions now showing params

Fixes #18892 - Do not show 'undefined method' in error message

Fixes #20072 - Allow thin host list via API

Fixes #19383 - document enabled host attribute

Fixes #17087 - default and overrides values converted to string

Fixes #19700 - update rubocop rules

The following changes have been made:

- Performance/RedundantMerge:
changes lines such as:
```not_found_message.merge! :message => options```
to:
```not_found_message[:message] = options```

- converts str.match() to str =~ ()...

Fixes #19125 - Add description to hostgroup

Fixes #17897 - update status api documentation

Fixes #19148 - Add description field to subnets

fixes #19035 - rewrite TopbarSweeper without rails-observers

Moves from the observer object into two mixins, one on the model and one
on the top-level controllers to observe creates/updates/destroys on
monitored models. Replaces rails-observers as it lacks Rails 5 support.

fixes #18719 - replace usage of deprecated Fixnum constant

Most type checks for Fixnum can safely be replaced by Integer, as prior
to Ruby 2.4, Fixnum was a subclass of Integer and so the conditional
holds.

Fixes #18065 - make API v1 deprecation warning more apparent

fixes #18064 - import host from compute resource

fixes #18476 - users have ssh keys

Fixes #18843 - Changed from eager_load to includes in #index

Avoiding multiple joins that result in very wide result rows.
It leads to big memory footprint in the DB especially on big datasets.
This big footprint translates then into DB high CPU usage while...

Fixes #18764 - Hammer-cli current user password update

Fixes #18317 - Clone user role via API

Fixes #12294 - Update existing params using API

refs #7495 - correct syntax in API error handler

Fixes #7495 - Create/delete autosign entries via API

Fixes #16846 - Org create failure with specific msg

Fixes #18410 - log permission denials

fixes #13618 - cache expensive vmware api calls

Fixes #12599 - Add config groups related apipie doc

Refs #15779 - make background processing unavailable for now (#4217)

The original PR got vetted in the packaging phase and including
foreman-task as dependency of Foreman was refused. We need to rethink
our approach for getting the foreman-tasks functionality available...

fixes #18214 - accept `params` as AC::Parameters or Hash

In Rails 5, ActionController::Parameters no longer inherits from Hash
and so type checks for params.is_a?(Hash) now return false and should
accept either. (Rails commit 14a3bd5.)

Refs #17653 - fix typo in show_hidden_parameters and add tests

Refs #17653 - add show_hidden to apidoc

Fixes #17653 - Allow all parameters api to unhide values

Fixes #17894 - load needed dependent api param group

when rendering facet api param docs

Fixes #13775 - merge if data set is present

Fixes #17678 - APIdoc - URL desc add missing CR types

Fixes #17525 - Add a friendly error message to invalid dns_id