Fixes #19789 - fix Layout/SpaceAroundOperators cop

Fixes #19775 - Fix Layout/ExtraSpacing cop

Fixes #23646 - Remove storeconfig leftovers

In Foreman 1.1 sharing the database with Puppet's storeconfigs was
deprecated. We've given users sufficient time to migrate away from it
and possibly broke it along the way. I haven't checked.

Fixes #19781 - Fix Layout/LeadingCommentSpace cop

fixes #23335 - normalize scsi attributes in rails 5 (#5475)

Fixes #23225 - fix vm tab js error in host page

Fixes #19787 - Fix Layout/SpaceAfterComma cop

Fixes #19894 - Fix Style/RedundantParentheses cop

Fixes #19796 - Fix Layout/SpaceInsidePercentLiteralDelimiters cop

Fixes #19839 - Fix Rails/Present cop

Fixes #23123 - Fix Rails/ActiveRecordAliases cop

Fixes #19895 - Fix Style/RedundantReturn cop

Refs #22285 - Prepare tests for strong params enforcement

- Fix broken hosts api tests
- Fix role cloning tests
- Fix ssh key controller api test
- Fix http proxies controller test
- Fix lookup key override api controller test
- Fix puppetclass controller api test...

Fixes #15984 - Avoid escaping overridden parameters (#5126)

Fixes #22779 - Calculate out of sync host via origin interval (#5221)

Fixes #21999,#22005 - Migrate toasts to pf-react

• Replace Alert and Toasts components with patternfly-react
• Refactor the server side flash-notification
• Allow rails-flah-notification to react-toast-notification with link

Fixes #19895 - Fix Style/RedundantReturn cop

Fixes #20931 - unify parameters and templates renderer (#4835)

• Fixes #20931 - unify parameters and templates renderer

Before this patch, we used separate renderer for the parameters. This
caused issues when introducing more dsl methods for the templates that...

fixes #22062 - support vmware vmrc console

Fixes #19782 - Fix Layout/MultilineArrayBraceLayout cop

Fixes #19769 - Fix Layout/CommentIndentation cop

Fixes #19780 - fix Layout/IndentationWidth cop

fixes #21825 - external nodes html content type

Fixes #20951 - Replace render :text with :plain

Fixes #20098 - Resolve template_used for image provisioning

At the moment, the method Hostext::OperatingSystem#template_kinds is
unable to handle image-based provisioning. If there is an image, it will
not be able to find it as 'self.compute_attributes' does not exist for...

fixes #20820 - set ajax vars for cr host import

fixes #20453 - build is enabled for cloned host (#4704)

Fixes #20248, #20327 - Respect context in CSV export

Since CSV export is done using an enumerator which is executed by a
different thread to the one that creates it, we need to manually pass in
the context (user, location, organization) to the enumerator.

Fixes #19031 - move to patternfly pagination style

fixes #4509 - VMWare: multiple scsi controllers

Fixes #19672 - fix bulk actions for plugins

fixes #19479, #10587, #19500 - two pane notifications are visible

- notification is now inside the content div, allowing two-pane server
responses to include it.
- refactored all notifications to use notification helpers (notice,
warning and error) instead of direct flash manipulation...

Fixes #16043 - add select all hosts option

fixes #12419 - template preview host has typeahead

fixes #18064 - import host from compute resource

Fixes #18760 - Allow export to CSV

This introduces a way of exporting tables from the UI to CSV.
There are 3 steps to adding a CSV export to a table:

1. Add the CsvResponder concern to the relevant controller.
2. Add a `format.csv` block to the index controller action. This block...

Fixes #16752 - Extract template code from Host::Managed

Host::Managed contains a lot of code related with determining the
template that a host should have. Other Host objects such as
Host::Discovered might need that logic, without becoming a
Host::Managed....

Fixes #18045 - Puppet classes show up choosing only env.

After #3551 was merged, the hosts controller requires both environment
and hostgroup to be set in order to display puppetclasses.

It shouldn't be required to have both, so we should check what's
available and use it. If it's only the hostgroup or the environment, it...

Fixes #3551 - Show unavailable Puppet Classes in Host Group edit

Puppet Classes can be assigned to a Host Group even if they are
not available in the set environment.

The Classes persist through out changes of the environment,
but were previously hidden from the UI this changes that....

Fixes #15403 - moved puppet to a concern in hosts UI controller

Fixes #17683 - Wrong resource type in HG AJAX permission check

Fixes #17503 - Only trigger PXELoader suggestion when needed

Previously every host instantiation triggered a PXELoader suggestion,
which led to up to 3 extra queries per host loaded. This changes so that
the suggestion is only applied when a host changes it's OS.

fixes #11127 - show error when rebuild reboot fails

Fixes #17343 - set deep munge config off

deep_munge was introduced as a solution to keep
Rails secure by default which results in
'empty array becomes nil in params'.
Thats why, set deep_munge config off in application.rb.
Also, added changes which will cast param argument to string...

refs #14688 - correct i18n extraction for all new power methods

- HOST_POWER being translated at the class level, not in action context
- messages with variables interpolated prior to i18n lookup
- timeout message being translated without prior extraction

Fixes #14688 - Power status visible on hosts index page

fixes #17409 - show only real bmc power actions

Fixes #16646 - Add ability to plugins to modify index scope

Fixes #16887 - Display errors from compute resource in VM tab

This commit allows these errors to show up in the VM tab. Without it
just a standard, unstyled 'internal server error' message shows up while
the error is only logged on Foreman's log.

fixes #16718 - remove relation.to_a.delete_if in multiple actions

To obtain a list of hosts where updating their build status etc. didn't
work, the controller relied on calling .to_a.delete_if on a relation and
then checking the result later. This doesn't work under Rails 5, it...

Refs #16689 - Missing DRY index action controllers

Some of the controllers that could have used the refactor in #16689 were
not added in that commit.

Additionally, I've fixed the '.includes' leftover in those controllers
from Rails 3 to be '.eager_load' now. '.includes' does not change the...

fixes #16578 - make keep_param idempotent, remove duplicate call

Using host_params (and keep_param) twice was causing compute_attributes
to be deleted permanently out of `params`. keep_param now restores
elements it deletes, and the controller now only calls host_params once...

Fixes #16491 - Upgrade rubocop to version 0.42

Fixes #14771 - Show corresponding os list for arch

refs #12544 - replace ordered interpolation with named variables

Fixes #12544 - added errors from host to cancelBuild
Now the flash will contain detailed error messages.

Fixes #13813 - Removed "\ " so ruby 1.8 could read the ENC

Fixes #15924 - Implement server groups and scheduler hints

Fixes #13768 - random and MAC-based name generator

fixes #3917 - replace protected_attrs with strong parameters

Filtering of attributes has moved from the protected_attributes gem to
strong parameters in controller concerns, to be in line with current
Rails recommendations.

Concerns are shared between UI and both API controllers and list the...

Refs #3809 - Using defaults for AndOr cop

fixes #15720 - rename *_filter to *_action

The older 'filter' name is changing in Rails to 'action' and is being
deprecated.

Refs #3809 - Turning on the AndOr cop

Refs #3809 - Turning on some rubocop cops

Fixes #14395 - Label for provision template capitalized in os details page

s

Fixes #5707 - disassociate does not appear for physical host

Fixes #6342 - merge compute profile when attributes in api host#create

API v2 host#craete call now merges user specified compute attributes
with compute profile. UI functionality remains untouched.

fixes #13647 - change puppet ca proxy for several hosts at once

fixes #13494 - change puppet proxy for several hosts at once

This commit adds the possibility to select multiple
hosts and change the puppet proxy for them.

fixes #13236 - apply power operations to several hosts at once

This commit adds the ability to select multiple hosts and apply power operations
(reboot, shutdown, boot) to them.

fixes #13004 - inherit compute profile from parent host groups

When selecting a compute resource on the New Host form and the VM
attributes tab is refreshed using an inherited compute profile, the
profile was taken from the host group only if explicitly set on it. The...

fixes #13039 - remove TemplateKind DB calls from UnattendedCtlr

UnattendedController created actions/methods during initialisation per
known TemplateKind, relying on the DB being populated. This caused
ordering issues when a plugin loaded the controller in a test...

fixes #12830 - Support rebooting hosts when building multiple hosts

When setting multiple hosts to build, this commit adds support to reboot the
hosts in addition to enabling rebuild.

Fixes #7230, #12021 - Upgrade to Rails 4.1.5

This commits upgrades Rails to Rails 4.1.5. See a description of the
changes included here, and go to the pull request in GitHub to see more
detailed explanations:

• Update gems to a Rails 4 compatible version, including dependencies...

Fixes #12618 - Now calls for compute attributes are explicit.

Prevents compute attributes from being overwritten unconditionally from
the hostgroup's compute profile.

fixes #1584 - bulk owner change

Fixes #12452 - Enable non admin users to do bulk actions on hosts

Fixes #11464 - use host inherited views for hostgroup parent parameters

fixes #4151 - enable reports STI

Permits subclassing of ReportImporter and Report to import and store
new types of reports associated to hosts.

Refs #10409 - Rails 4 compatible changes with Rails 3

This includes some changes that can be applied to Rails 3 without
any issue and don't follow any particular pattern/deprecation, In
general these are minor things we have to change. Other PRs with
retrocompatible changes that aim to fix particular deprecations...

Fixes #11767 - avoid cleaning of interface attributes

Fixes #2943,#11387 - Add unset option to password_f in layout helper, added in Host and hostgroup root_pass, LDAP acount password, BMC password and compute resources password

#2943,#11387 - Please enter the commit message for your changes. Lines starting

Fixes #2267 - general rebuild of TFTP, DNS, DHCP

Fixes #10782 - global host status

• OK
• WARN
• ERROR

Plugins can add their own substatuses. These are automatically...

fixes #9058 - interfaces should not be affected when changing loc/org

Fixes #9591 - Added support for "inherit" state.

Refs #3809 - Enable cop Style/AlignArray

Fixes #9603 - fixed websockets_* set of settings

Refs #3809 - Style/blocks cop enabled

Fixes #10713 - improved backtrace logging

• full trace in 500 page in production shows really the full trace
• Foreman::Logging.exception as an unified entry point for exceptions logging
• the backtrace cleaner doesn't delete the plugins
• the orchestration exceptions gets the backtrace covered by logger...

Refs #10337 - Update Host searches to use outofsync_interval

Fixes #10337 - Added setting out of sync duration

fixes #10342 - adding :host_parameters_attributes to except list in template_used()

Fixes #10111 - Use a dummy primary interface for unmanaged hosts

Unmanaged hosts require a host interface due to delegation of networking
attributes, and some others like 'name'. Since unmanaged hosts do not
necessarily have an interface associated (unless created through puppet...

Fixes #9480 - multiple NICs integration with compute profiles

From users point of view:
- interfaces setup in compute profiles is back
- interface related compute attrs get merged into host NICs upon compute
profile selection
- NIC overview table displays details in the column "Type"...

Fixes #8736 - confirmation before host delete for freshly created hosts

Refs #3809 - Remove classcheck cop

Refs #3809 - Remove cops for empty lines

Fixes #9231 - Require English lib and fix ENC failure

Fixes #7456 - Extract primary interface from host

• Tomas Strachota (tstrachota) <tstrachota@redhat.com>
• Marek Hulán (ares) <mhulan@redhat.com>
• Gregory Sutcliffe (GregSutcliffe) <gsutclif@redhat.com>

All host must have at least one primary interface and one provision (can...