Fixes #19789 - fix Layout/SpaceAroundOperators cop

Fixes #21580 - normalize compute attributes (#4980)

Normalizes compute attributes in API show actions. For backwards
compatibility reasons this patch adds a new rabl node instead of
replacing 'vm_attrs'.

Fixes #19787 - Fix Layout/SpaceAfterComma cop

Fixes #19832 - Fix Rails/FindBy cop

Fixes #20174 - handle no storage pool gracefully

fixes #3917 - replace protected_attrs with strong parameters

Filtering of attributes has moved from the protected_attributes gem to
strong parameters in controller concerns, to be in line with current
Rails recommendations.

Concerns are shared between UI and both API controllers and list the...

Refs #3809 - Using defaults for AndOr cop

Refs #3809 - Turning on some rubocop cops

fixes #14415 - check CR availability with Fog, not SETTINGS

Simplifies the code for checking compute resource availability, which
can easily be determined with the registered Fog providers instead of
being stored in SETTINGS in app initialisation. Plugins should always be...

fixes #14170 - permit 'zone' parameter for GCE CR creation

Fixes #12911 - Turning on 0.35.1 cops

Fixes #7568 - Use attr_accessible for Rails 4 upgrade

Fixes #4551 - GCE provisioning support

Enable provisioning of VMs through Google Compute Engine. Volume-wise,
this is currently limited to creating a VM with an attached disk that
contains the image specified. Future enhancements should include
choosing any available disks to auto-attach the VM and not force the...

Fixes #10713 - improved backtrace logging

• full trace in 500 page in production shows really the full trace
• Foreman::Logging.exception as an unified entry point for exceptions logging
• the backtrace cleaner doesn't delete the plugins
• the orchestration exceptions gets the backtrace covered by logger...

Refs #3809 - Remove cops for empty lines

Fixes #8258 - CR provider errors with correct log level

Refs #3809 - Use parentheses in method definitions

Refs #3809 - Remove rubocop TODOs

Removed the following TODOs so that cops for these will run from now on:

Lint/AmbiguousOperator, DefEndAlignment, DeprecatedClassMethods
EnsureReturn, RequireParentheses, Void, BlockAlignment, EndAlignment,
UselessAccessModifier,...

Fixes #6099 - Bubble Fog::Errors up to Host

fixes #4612 show friendly CR names, fix typo in oVirt name

fixes #3867 - Wrong Compute Resource type shown on overview

fixes #3832 - foreman supplies user for GCE images, fog expects username

fixes #3110 Association of vSphere VMs fails

fixes #1719 - Add support for GCE