Fixes #19858 - Configure Style/EmptyMethod cop (#5703)

• Refs #20891 - fix for new rubocop rules

• Fixes #19858 - Configure Style/EmptyMethod cop

fixes #23909 - vsphere: prefer network search by key

Creating a new VMware image fails during provisioning with
"Could not match network interface". Searching for distributed
virtual switch via key BEFORE searching with the nic_attrs structure
resolves a false positive match when vCenter contains VDS migrated...

refs #19623 - fix if key method is not present for network

credit to jsherrill for the one line solution :)

Fixes #19623 - add comparison to portkey for vmware networks

Fixes #5483,#11106 - pass the virtualswitch value to fog

We can't pass the network id directly to the fog, but it accepts the
virtualswitch parameter, that we can use to point to the right value.

Also, it fixes another issue, where we used the vsphere network id to...

fixes #3910 - add cdrom drive support for vmware

Refs #3809 - Turning on some rubocop cops

Fixes #10186 - find host NICs on vsphere using Network Distributed PortGroup

Refs #3809 - Remove cops for empty lines

Fixes #7456 - Extract primary interface from host

• Tomas Strachota (tstrachota) <tstrachota@redhat.com>
• Marek Hulán (ares) <mhulan@redhat.com>
• Gregory Sutcliffe (GregSutcliffe) <gsutclif@redhat.com>

All host must have at least one primary interface and one provision (can...

fixes #4590 - convert VMware SCSI controller type during creation

fixes #2438 - Add image build capability to vsphere using templates

fixes #3496 vSphere: add support for selectable SCSI controller

fixes #3178 - add feature for compute profiles for hostgroups and hosts

fixes #2411 - move lib/audit_extensions lib/fog_extensions lib/foreman to models/concerns

fixes #2739 - add ActiveSupport::Concern syntax to mixins