Fixes #19789 - fix Layout/SpaceAroundOperators cop

Fixes #19775 - Fix Layout/ExtraSpacing cop

Fixes #19781 - Fix Layout/LeadingCommentSpace cop

Fixes #15411 - Move smart_proxy_ids_for to Host

Fixes #19787 - Fix Layout/SpaceAfterComma cop

Fixes #19839 - Fix Rails/Present cop

Fixes #19832 - Fix Rails/FindBy cop

Fixes #18854 - Search by usergroup on hosts (#5317)

Fixes #22779 - Calculate out of sync host via origin interval (#5221)

Fixes #22556 - Correct host search for parent hostgroup

Currently, searching on a non-existant parent fails due to
`hostgroup.subtree_ids` throwing a NoMethodError when no matching
hostgroup is found. This is rescued by scoped search, causing the
search to run with no conditions instead....

Fixes #20667 - Reduce implicit searching on host index (#4768)

Fixes #20950 - Use 'distinct' in AR finders

Refs #17272 - fix sql condition

1==1 is not a valid SQL condition.

Fixes #17272 - Fixed Searches on parameters with !=

Fixes #12547 - Added validators to interger fields

With this commit, instead of postgresql exception it will
show proper validation message for interger fields.

fixes #18024 - add 'image' search field to hosts

fixes #17574, #17364 - update scoped_search to 4.x

scoped_search's sort() now accepts a replacement for params which is
filtered in an overridden Foreman sort helper, permitting additional
parameters used in Foreman's index pages.

Replaces :in and :alias in search definitions with preferred keywords.

Fixes #16565 - Correct host search by parameters

Overrides for parameters values caused incorrect results for when
searching by parameter value. This commit fixes those results, and
improves the handling of parameter priorities in general. A new rake
task, `parameters:reset_priorities` is introduced that should be invoked...

Fixes #16491 - Upgrade rubocop to version 0.42

Fixes #16358 - Load dashboard on puppet proxy view

Some changes made to the main dashboard caused the puppet dashboard on
the smart proxy page to break.
This commit also includes small improvements to the dashboard loading
performance.

Fixes #12193 - Stop using counter_cache for host[group] counts

This is aimed to prevent deadlocks caused by Rails' implementation of
counter_cache that is hit when multiple hosts are created or updated at
the same time. An added benefit is that the counters will now display...

fixes #14664 - support IPv6 in Nic, Hosts and Hostgroups models

Fixes #15050 - Scoped search hostname w/o field no longer ISEs

Searching for an existing host's name without any fields
specified results in an SQL error:
missing FROM-clause entry for
table \"organizations_hosts\"

This can be reproduced using
curl -X GET -u admin 'http://localhost:3000/api/v2/...

Refs #3809 - Turning on some rubocop cops

Fixes #14730 - Only search host proxies explicitly

When searching hosts with free text in a taxonomy scope, if the taxonomy
has "all smart proxies" associated, it leads to scoped search generating
an incorrect scope which causes an invalid query:
`SELECT smart_proxies.id FROM "smart_proxies" "puppet_ca_proxies_hosts"`...

Fixes #14190 - consistent api output and search options

Fixes #3582 - Parameters on subnets

Fixes #13937 - search by domain parameters searches on primary_interface

Fixes #13348 - Allow searching of all hosts managed by a smart proxy

Fixes #12891 - search_by_params and search_by_user for host return correct results

fixes #12194 - join fact tables multiple times for each search term

scoped_search usually generates a new inner join for each search term
when searching through a key/value table layout to correctly search for
hosts via multiple facts. Since the change to ext_method in 3f8e6c33, a...

fixes #12458 - escape values in fact searches to prevent SQL injection

fixes #4151 - enable reports STI

Permits subclassing of ReportImporter and Report to import and store
new types of reports associated to hosts.

Fixes #10782 - global host status

• OK
• WARN
• ERROR

Plugins can add their own substatuses. These are automatically...

Fixes #11150 - Allow searching of facts as types other than string

Fixes #10583 - perform uniq in database instead of in memory when possible

Fixes #7458 - allow searching hosts by their ip and mac addresses

Refs #3809 - Remove cops for empty lines

Fixes #7456 - Extract primary interface from host

• Tomas Strachota (tstrachota) <tstrachota@redhat.com>
• Marek Hulán (ares) <mhulan@redhat.com>
• Gregory Sutcliffe (GregSutcliffe) <gsutclif@redhat.com>

All host must have at least one primary interface and one provision (can...

Fixes #7523 - Removed autocomplete search from id fields

Fixes #5573 - os search definitions for host available in unattended=false mode

Fixes #8043 - Statistic links to OS

Refs #3809 - Remove rubocop TODOs

Removed the following TODOs so that cops for these will run from now on:

Lint/AmbiguousOperator, DefEndAlignment, DeprecatedClassMethods
EnsureReturn, RequireParentheses, Void, BlockAlignment, EndAlignment,
UselessAccessModifier,...

Fixes #6468 - Allow filtering/searching by active user

fixes #7035 - expand column name for Rails 3.2.8 compat in Puppet class search

Fixes #6830 - Add host search on compute_resource_id used in 1.5 auth migrations

fixes #5994: Power and Console buttons are available to non-admin users with appropriate permissions

fixes #5848 - can't search for host with class inherited from config group

fixes #6116 - search hosts by parent host group and its decendants

Fixes #5664 - Host filters can use taxonomies

Also disables taxonomy filters on resources that do not support them.

fixes #4204 - add config groups feature - assign multiple config groups to a host or hostgroup

fixes #4670: switch search to id on OS page

fixes #1809 - foreman realm integration

fixes #4691 - add search for hosts' managed status

fixes #1804 - find hosts through nested hostgroups on puppet class search

fixes #4314 - ignore default scope ordering on host search by puppet class

fixes #3001 - Facts searchable by both host id and name

fixes #812 - new permissions model, user group role and nest support, role filters for better granularity

• Daniel Lobato <elobatocs@gmail.com>
• Joseph Magen <jmagen@redhat.com>
• Tom McKay <thomasmckay@redhat.com>
• Greg Sutcliffe <gsutclif@redhat.com>...

fixes #4393 - rename ancestry label to title

fixes #3912 - add inheritance for locations / organizations

Fixes #3720 - Add description field to operatingsystem

fixes #2871 - params search works with nested hostgroups

fixes #2739 - add ActiveSupport::Concern syntax to mixins

fixes #2411 - move files in /models to /concerns, /services, /mailers, /observers