Fixes #19858 - Configure Style/EmptyMethod cop (#5703)

• Refs #20891 - fix for new rubocop rules

• Fixes #19858 - Configure Style/EmptyMethod cop

Fixes #19873 - Fix Style/MultilineIfModifier cop (#5705)

• Refs #20891 - fix for new rubocop rules

• Fixes #19873 - Fix Style/MultilineIfModifier cop

Fixes #23857 - Fix Performance/InefficientHashSearch cop

Fixes #23859 - Fix vm_exists? method

Fix related tests

Fixes #23859 - Queue orchestration compute

Fixes #23145 - fix strong params for compute attributes on fail (#5412)

Fixes #19787 - Fix Layout/SpaceAfterComma cop

Fixes #19832 - Fix Rails/FindBy cop

Fixes #17083 - log skipped orchestration steps

Fixes #19907 - Configure Style/TernaryParentheses cop

Fixes #19459 - improve vm boot failure feedback

To be able to override the wait for vm ready we need to move
it to compute resource definition. Also improve Openstack one

fixes #18064 - import host from compute resource

Fixes #3541,#13769 - return true on success of ssh orchestration

Strange things start happening otherwise.

fixes #18216 - volume size editable for existing VMs one

Fixes #16782 - reset dhcp record cache after mac change

Fixes #17343 - set deep munge config off

deep_munge was introduced as a solution to keep
Rails secure by default which results in
'empty array becomes nil in params'.
Thats why, set deep_munge config off in application.rb.
Also, added changes which will cast param argument to string...

fixes #17071 - set ip after acquiring compute details

fixes #16951 - ipv6 compute orchestration

Refs #3809 - Using defaults for AndOr cop

Refs #3809 - Turning on the AndOr cop

Refs #3809 - Turning on some rubocop cops

Fixes #6959 - set operating system for RHEV/ovirt VMs

Backward compatible, but works best with https://github.com/abenari/rbovirt/pull/104

Fixes #13986 - don't use image unless in image provisioning method

Fixes #13084 - compute resource IP orchestration fixed

Refs #12911 - Fixing colon method calls

Fixes #12946 - Do not fail miserably when compute instance is not found.

fixes #12517 - VMWare VM should be created network based only if it is selected in the gui

Fixes #10072: Support for user-data during image-based provisioning with libvirt (used for creating of Atomic libvirt VM)

Fixes #10713 - improved backtrace logging

• full trace in 500 page in production shows really the full trace
• Foreman::Logging.exception as an unified entry point for exceptions logging
• the backtrace cleaner doesn't delete the plugins
• the orchestration exceptions gets the backtrace covered by logger...

Fixes #7096 - Adds STI to templates

This commit converts Ptables to be just another type of Template so it
gets the same features as ConfigTemplate. ConfigTemplate was renamed to
ProvisioningTemplate to reflect UI and the name under it's commonly known.

Fixes #10684 - re-adding missing code

Fixes #9170 - wrong nic order in libvirt domain

Fixes #9966 - More debug messages for matching nics from fog

Fixes #6454 - Display error message when user_data is needed but not set

Fixes #9480 - multiple NICs integration with compute profiles

From users point of view:
- interfaces setup in compute profiles is back
- interface related compute attrs get merged into host NICs upon compute
profile selection
- NIC overview table displays details in the column "Type"...

Refs #3809 - Remove cops for empty lines

Fixes #7456 - Extract primary interface from host

• Tomas Strachota (tstrachota) <tstrachota@redhat.com>
• Marek Hulán (ares) <mhulan@redhat.com>
• Gregory Sutcliffe (GregSutcliffe) <gsutclif@redhat.com>

All host must have at least one primary interface and one provision (can...

Refs #3809 - Use parentheses in method definitions

Refs #3809 - Fix a few rubocop TODOs

Refs #3809 - Remove rubocop TODOs

Removed the following TODOs so that cops for these will run from now on:

Lint/AmbiguousOperator, DefEndAlignment, DeprecatedClassMethods
EnsureReturn, RequireParentheses, Void, BlockAlignment, EndAlignment,
UselessAccessModifier,...

Fixes #6160 - don't validate images for network based provisioning

Fixes #4710, #2270 - Wait for VM to become ready before looking for IPs

Fixes #4616 - Add a Fog mixin for looking up EC2 IP addresses

fixes #4123 - libvirt imaging support using backing volumes

Fixes #2270 - Detect all OpenStack IPs and test which allows SSH

fixes #4173 - don't update CR attrs when none available, taken from GH-1184

Fixes #3927 - Allow VMs to provision via user-data

fixes #2975 added setting for using the shortname instead of FQDN for new virtual machines

Fixes #2867: use the future relative tense for the orchestration process during provisioning

fixes #2739 - add ActiveSupport::Concern syntax to mixins

fixes #2411 - move files in /models to /concerns, /services, /mailers, /observers