Fixes #19873 - Fix Style/MultilineIfModifier cop (#5705)

• Refs #20891 - fix for new rubocop rules

• Fixes #19873 - Fix Style/MultilineIfModifier cop

Fixes #23857 - Fix Performance/InefficientHashSearch cop

Fixes #23859 - Fix vm_exists? method

Fix related tests

Fixes #23859 - Queue orchestration compute

Fixes #19781 - Fix Layout/LeadingCommentSpace cop

Fixes #23145 - fix strong params for compute attributes on fail (#5412)

Fixes #19787 - Fix Layout/SpaceAfterComma cop

Fixes #23081 - Fix Style/SafeNavigation cop

Fixes #19894 - Fix Style/RedundantParentheses cop

Fixes #19832 - Fix Rails/FindBy cop

Fixes #21120 - orchestration tasks are added only once (#5079)

Fixes #17083 - log skipped orchestration steps

Fixes #19907 - Configure Style/TernaryParentheses cop

Fixes #19879 - Fix Style/NestedParenthesizedCalls cop

Fixes #22078 - Fix Rails/EnvironmentComparison cop

Fixes #21120 - DHCP update no longer queued twice

Fixes #19772, #19773, #19774 - Fix some empty line cops

Fixes #19677 - Add settings for local boot templates

Fixes #19700 - update rubocop rules

The following changes have been made:

- Performance/RedundantMerge:
changes lines such as:
```not_found_message.merge! :message => options```
to:
```not_found_message[:message] = options```

- converts str.match() to str =~ ()...

Fixes #19459 - improve vm boot failure feedback

To be able to override the wait for vm ready we need to move
it to compute resource definition. Also improve Openstack one

Fixes #19534 - improved orchestration task logging

fixes #19328 - autosign tasks have correct wording

Fixes #15374 - move progress_report_id to Host::Base

fixes #18064 - import host from compute resource

fixes #17533 - provision dhcp for bond child macs

Fixes #3541,#13769 - return true on success of ssh orchestration

Strange things start happening otherwise.

fixes #18216 - volume size editable for existing VMs one

Fixes #16782 - reset dhcp record cache after mac change

fixes #17853 - resolve ips in interface scope

fixes #17485 - provision tftp for bond children

Fixes #17343 - set deep munge config off

deep_munge was introduced as a solution to keep
Rails secure by default which results in
'empty array becomes nil in params'.
Thats why, set deep_munge config off in application.rb.
Also, added changes which will cast param argument to string...

fixes #17071 - set ip after acquiring compute details

fixes #17197 - don't update DNS on ip6 change to empty string

fixes #16951 - ipv6 compute orchestration

fixes #16819 - rebuild tftp with template kinds

Fixes #16439 - Don't fail recreate if DNS is ok

If rebuilding a host and DNS is not "feasible" we don't want to fail
that host but rather recreate what's currently feasible.

If a DNS record is still valid we don't want to fail that host but
rather take the still valid entry.

fixes #15590 - ipv6 tftp orchestration

refs #12634 - remove blank i18n string, match capitalisation

Fixes #12634 - New HW Model flag pxe_loader

Implementation of

https://github.com/theforeman/rfcs/blob/master/text/0001-PXE-Booting-UEFI.md

In short, new host/hostgroup flag PXE loader is added to specify TFTP
DHCP filename and Foreman now orchestrates all PXE-capable templates...

Refs #3809 - Using defaults for AndOr cop

fixes #15709 - fix SuSE mediapath in PXELinux templates

Refs #3809 - Turning on the AndOr cop

fixes #15635 - tests for dns orchestration

Fixes #15306 - Catches exceptions in the orchestration

fixes #14663 - support IPv6 DNS orchestration

Fixes #14955 - Show nice message for invalid mac, ip

fixes #14664 - support IPv6 in Nic, Hosts and Hostgroups models

Fixes #6539 - missing templates error is now descriptive

fixes #14905 - enable DHCP orchestration with any boot mode

DHCP orchestration remains useful to set up PXE booting to start the
provisioning process, even when a static boot mode because the boot mode
is typically applied later through templates. It's also useful in image...

fixes #12425 - do not trigger orchestration during fact import

fixes #14642 - support AAAA and PTR-Records in dns lib

Refs #3809 - Turning on some rubocop cops

Fixes #14521 - better error on missing PXELinux template

Fixes #6959 - set operating system for RHEV/ovirt VMs

Backward compatible, but works best with https://github.com/abenari/rbovirt/pull/104

Fixes #13986 - don't use image unless in image provisioning method

fixes #12962 - Add Xenserver to list of supported OS families.

Templates are included in community-templates repo.

Fixes #5859 - don't rely on a mac address being present when overriding the conflicts

We tried to initiate the `dhcp_record` for checking if conflicts were
there. The problem was the mac address was not available at that stage
when using the compute resources. It also turns out there is no need...

Fixes #14113 - run dhcp orchestration only on DHCP subnets

Fixes #13084 - compute resource IP orchestration fixed

Refs #12911 - Fixing colon method calls

fixes #13297 - ssh_provision: try keyboard-interactive as well

With password auth try keyboard-interactive as well since (non PAM
based) password authentication might be disabled in sshd_config (as e.g.
on SLES12).

Fixes #12946 - Do not fail miserably when compute instance is not found.

fixes #12517 - VMWare VM should be created network based only if it is selected in the gui

fixes #12345 - fix sparc host creation

Fixes #11987 - Check exit code of deployment scripts

This commit fixes checking exit codes returned from provisioning templates, which were ignored
because of sending results through pipe to command tee. Also adds optional host deleting if deployment
fails because of non zero exit code. This can be configured by setting clean_up_failed_deployment...

Fixes #12067 - Delegated methods need to be public, not protected

generate_pxe_template and require_ip_validation? are delegated to
primary interface on Host::Managed. However, these methods are
protected. On Rails 4, protected methods cannot be called through a...

Fixes #11850 - improved DNS error message

Fixes #11709 - better error for DNS conflict timeouts

Fixes #2267 - general rebuild of TFTP, DNS, DHCP

Fixes #10072: Support for user-data during image-based provisioning with libvirt (used for creating of Atomic libvirt VM)

Fixes #10713 - improved backtrace logging

• full trace in 500 page in production shows really the full trace
• Foreman::Logging.exception as an unified entry point for exceptions logging
• the backtrace cleaner doesn't delete the plugins
• the orchestration exceptions gets the backtrace covered by logger...

Fixes #7096 - Adds STI to templates

This commit converts Ptables to be just another type of Template so it
gets the same features as ConfigTemplate. ConfigTemplate was renamed to
ProvisioningTemplate to reflect UI and the name under it's commonly known.

Fixes #10684 - re-adding missing code

fixes #1510 - notification when host finishes building

Fixes #9170 - wrong nic order in libvirt domain

Fixes #9634 - creating a host with an interface and without os returns a validation message

Fixes #9966 - More debug messages for matching nics from fog

Fixes #10307 - editing host with 'unattended: false' no longer results in error

fixes #10020 - add next-server/filename attrs to provision NIC DHCP record

A host's DHCP record used to be constructed with PXE attributes in
Orchestration::DHCP, but moved to Nic::Managed during 43c4bd7. Nic::Managed
didn't add PXE attributes, so this commit adds these when provision? is set....

Fixes #6454 - Display error message when user_data is needed but not set

Fixes #1536 - Foreman should check DHCP entries on build.

Fixes #9480 - multiple NICs integration with compute profiles

From users point of view:
- interfaces setup in compute profiles is back
- interface related compute attrs get merged into host NICs upon compute
profile selection
- NIC overview table displays details in the column "Type"...

Fixes #9147 - move managed checks to the start of the DHCP/DNS/TFTP orchestration checks

fixes #9397 - Make usage of @host.operatingsystem in UnattendedController consistent

Changed all host.os to host.operatingsystem

Refs #3809 - Remove classcheck cop

Refs #3809 - Remove cop IndentationConsistency

Refs #3809 - Remove cops for empty lines

fixes #8953 - update IPA userclass param on realm update

fixes #9369 - tftp should send host, not self to get the boot files uri

Fixes #9160 - use provision interface for image based provisioning

Fixes #7456 - Extract primary interface from host

• Tomas Strachota (tstrachota) <tstrachota@redhat.com>
• Marek Hulán (ares) <mhulan@redhat.com>
• Gregory Sutcliffe (GregSutcliffe) <gsutclif@redhat.com>

All host must have at least one primary interface and one provision (can...

Refs #3809 - Remove useless assignments

Refs #3809 - Use parentheses in method definitions

Refs #3809 - Fix a few rubocop TODOs

Refs #3809 - Remove rubocop TODOs

Removed the following TODOs so that cops for these will run from now on:

Lint/AmbiguousOperator, DefEndAlignment, DeprecatedClassMethods
EnsureReturn, RequireParentheses, Void, BlockAlignment, EndAlignment,
UselessAccessModifier,...

fixes #4672 - added template_name template variable

Fixes #7418 - fixed capitalization for some AR errors

[REFACTOR] refs #6229 - extract validation to a method

this enables plugins (e.g. katello) to override the validation when
requried.

Fixes #6160 - don't validate images for network based provisioning

Fixes #5637 - Don't raise lease conflicts when reading ad-hoc DHCP leases