Refs #3809 - Stabby lambda syntax for oneliners
I started by spotting log.rb which didn't have a lambda wrapping itsdefault scope, as needed by Rails 4. Since the style guide and mostRails 4 documents used the stabby lambda, I turned on the cop so that we...
Refs #3809 - Remove semicolon cop
Refs #3809 - Remove cops for empty lines
Fixes #6710 - unicode characters in url parameters
Original methods to_param defined on resources called name.parameterizeto get rid of url-unsafe characters. This function unfortunately alsostripped off unicode characters.
Changes:- parameterization extracted into a separate module Parameterizable...
Fixes #5139 - leftovers subscribe_to_all_hostgroups
Remove user_xxx unnecessary tables and notices
Update subhostgroups removed
Fixes for migration of foreign keys
Remove users from compute_resource fixture
Remove table notices after fk are removed for pg/mysql
Refs #3809 - Remove rubocop TODOs
Removed the following TODOs so that cops for these will run from now on:
Lint/AmbiguousOperator, DefEndAlignment, DeprecatedClassMethodsEnsureReturn, RequireParentheses, Void, BlockAlignment, EndAlignment,UselessAccessModifier,...
fixes #6636, #6657, #6694 - add field length validations, extend audit field length
fixes #3339 - nested fact support, allow fact importers to be registered by plugins
fixes #2741 - rails 3 syntax
fixes #2801 - remove LOWER in default_scope of models that could cause PG error
fixes #2509, fixes #2507: few issues around Host::Base#merge_facts and fact names
fixes #2421 added missing has_many :hostgroups and missing :dependent => destroy
fixes #2254 - Add STI to hosts table
Signed-off-by: Joseph Mitchell Magen <jmagen@redhat.com>Signed-off-by: Ohad Levy <ohadlevy@gmail.com>
updated migrations to use puppet Rails function of creating the db schema, adjusted what ever it took to get the first Fedora 11 client installed with our kickstart
added facts controllers
added fact models, aligned db schema with puppet schema, removed unneeded columns