Fixes #19873 - Fix Style/MultilineIfModifier cop (#5705)

• Refs #20891 - fix for new rubocop rules

• Fixes #19873 - Fix Style/MultilineIfModifier cop

Fixes #19789 - fix Layout/SpaceAroundOperators cop

Fixes #19787 - Fix Layout/SpaceAfterComma cop

Fixes #19840 - Fix Rails/ReadWriteAttribute cop

Fixes #19839 - Fix Rails/Present cop

Fixes #22331 - Fix Rails/Presence cop

Fixes #22918 - Audit all taxonomies assignments

We need to move all audited definitions to top of models because all
concerns can use audit_associations call which relies on audit being
already activated.

Refs #16740 - migration templates to use param macros

Fixes #15711 - Redesigned host info to providers.

Now you can add your own info by registering a
host method that will return info hash.

Fixes #13772 - orchestration now uses app logger

Fixes #18813 - Sort matchers by priority

Fixes #17874 - Extract contains_erb? from lookup key

fixes #17574, #17364 - update scoped_search to 4.x

scoped_search's sort() now accepts a replacement for params which is
filtered in an overridden Foreman sort helper, permitting additional
parameters used in Foreman's index pages.

Replaces :in and :alias in search definitions with preferred keywords.

Fixes #16378 - Move default_value casting to lookup_key children

Refs #15814 - Reset override params only for PuppetclassLookupKey

Fixes #15814 - Reset override params when override is off

fixes #3917 - replace protected_attrs with strong parameters

Filtering of attributes has moved from the protected_attributes gem to
strong parameters in controller concerns, to be in line with current
Rails recommendations.

Concerns are shared between UI and both API controllers and list the...

Refs #12193 - Remove remaining cached counters

Fixes #15534 - Stop stripping whitespace in parameter values

Fixes #14432 - Removing scoped search on value for smart class parameter

Fixes #14183 - showing whitespace validation in smart variables

Fixes #13899 - Can update smart class parameter type from API

Fixes #13519 - Alias lookupkey key to parameter

Fixes #9553 - Remove workaround for older json version

We already use json 1.8, this workaround is no longer needed.

fixes #12805 - nested LV in puppetclass form are now validated

Callbacks return false ONLY if they NEED to stop EVERYTHING else from
running!
DO NOT return false if you want to say "this isn't valid"

Refs #6007 - fixing safe_value for lookup key

Fixes #12806 - adding merge_default to attr_accessible in lookup_key

Fixes #12180 - lookup_value presence validation moved from lookup_key

Global parameters can have empty values so smart variables that are also global should be allowed to accept empty values too.
The validation on lookup_value to make sure it isn't empty is in the LookupKey class therefore affecting both VariableLookupKey and PuppetClassLookupKey....

fixes #11862 - validating that casted hash is valid

Catch parse errors correctly under Ruby 1.9.3, and ensure the uncasted
value is displayed back in the UI if it fails to parse.

Fixes #6007 - Allowing to hide smart class parameters

Fixes #7568 - Use attr_accessible for Rails 4 upgrade

Fixes #11458 - Override inline for class parameters

This implements override inline for smart class parameters and smart
variables in host and hostgroup edit forms.
Global variable override inline will be done in a seperate PR.

Authors:
Ori Rabin <orrabin@redhat.com>...

fixes #12095 - prevent escaping of lookup key default value with ERB

When the current default value is retrieved from a lookup key via
default_value_before_type_cast, do not re-dump values containing ERB as
they will not have been cast already. This prevents them being escaped...

fixes #11964 - mark existing parameters as overridden during clone

Fixes #11851 - include ActiveRecord::Base.inherited as super in LookupKey.inherited

fixes #10832 - separating lookup keys into puppet and variable