Fixes #19789 - fix Layout/SpaceAroundOperators cop

Fixes #23857 - Fix Performance/InefficientHashSearch cop

Fixes #23800 - i18n for exceptions fixed

Fixes #19839 - Fix Rails/Present cop

fixes #21694 - Add MTU to subnet

Refs #22918 - fix Layout/EmptyLines cop

[ci skip]

Fixes #22918 - Audit all taxonomies assignments

We need to move all audited definitions to top of models because all
concerns can use audit_associations call which relies on audit being
already activated.

Fixes #17316 - templates feature is subnet association

refs #22107 - subnet host count: permissions and n+1

Fixes #1916 - Subnet vlan id should be integer

Fixes #22107 - Add hosts count to subnet page

Fixes #20957 - Replace alias_method_chain with Module prepend

Deprecated in Rails 5.0 and will be removed in 5.1. Some instances of
classes overwriting existing methods can be handled with `super`, other
concerns or modules are changed to use prepend instead of include....

Fixes #20950 - Use 'distinct' in AR finders

Fixes #13772 - orchestration now uses app logger

Fixes #19148 - Add description field to subnets

fixes #18176 - replace clear_association_cache with reload

Reload is still necessary in Rails 5 as interfaces association will be
cached. The BMC test change is necessary to reload smart proxies
associated to the subnet after their features were altered - previously...

fixes #17574, #17364 - update scoped_search to 4.x

scoped_search's sort() now accepts a replacement for params which is
filtered in an overridden Foreman sort helper, permitting additional
parameters used in Foreman's index pages.

Replaces :in and :alias in search definitions with preferred keywords.

fixes #17095 - ensure subnet belongs to ip from facts

fixes #16725 - add plugin extension point for smart proxies

fixes #3917 - replace protected_attrs with strong parameters

Filtering of attributes has moved from the protected_attributes gem to
strong parameters in controller concerns, to be in line with current
Rails recommendations.

Concerns are shared between UI and both API controllers and list the...

Refs #3809 - Using defaults for AndOr cop

fixes #14666 - support IPv6 in UI

Refs #3809 - Turning on the AndOr cop

Refs #3809 - Turning on some Lint cops

fixes #15508 - allow duplicate networks

fixes #14665 - support IPv6 via API

fixes #14663 - support IPv6 DNS orchestration

Fixes #5785 - override class parameter by subnet name

fixes #14664 - support IPv6 in Nic, Hosts and Hostgroups models

fixes #14509 - refactor enc_output to be a generic exporter

Refs #3809 - Turning on some rubocop cops

fixes #14661 - support IPv6 subnets

fixes #14638 - Refactor Subnet into STI to allow different subnet types

Fixes #3582 - Parameters on subnets

Fixes #13711 - fix subnet/domain validation during creation

Fixes #6241 - Validations for associations with proxies

Fixes #12884 - Allow importing subnets from smart proxy

Fixes #7230, #12021 - Upgrade to Rails 4.1.5

This commits upgrades Rails to Rails 4.1.5. See a description of the
changes included here, and go to the pull request in GitHub to see more
detailed explanations:

• Update gems to a Rails 4 compatible version, including dependencies...

Fixes #7568 - Use attr_accessible for Rails 4 upgrade

Fixes #12457 - Use .exists? to check subnet exists on Rails 4

On app/models/subnet.rb, the method `self.import` uses `if
first(:conditions => attrs)`. It no longer is an alias for
`find(:first, *args)` but now it just fetches the first X
records (`first(X)`). `.exists?` is a suitable equivalent

Fixes #12212 - Import addtitionnal informations from DHCP smart proxy

fixes #11250 - Remove uniqueness check from subnet network addresses

Fixes #10487: Add custom logging support

This change moves away from the Rails logger to the 'logging' gem
to support more configurability of logging. Further, this allows for
the creation of custom loggers that plugins can then create during
registration (with `logger`) or through settings....

Fixes #10583 - perform uniq in database instead of in memory when possible

fixes #10287 - provide helper methods for proxy features

Fixes #8779 - add vlanid to subnet ENC

Refs #3809 - Remove cops for empty lines

Refs #3809 - Enable cop StringConversionInInterpolation

Fixes #7456 - Extract primary interface from host

• Tomas Strachota (tstrachota) <tstrachota@redhat.com>
• Marek Hulán (ares) <mhulan@redhat.com>
• Gregory Sutcliffe (GregSutcliffe) <gsutclif@redhat.com>

All host must have at least one primary interface and one provision (can...

fixes #8685 - include netmask in ENC output

fixes #7975 - Subnet names should be unique

Fixes #2089 - Add network configuration to ENC

Fixes #6710 - unicode characters in url parameters

Original methods to_param defined on resources called name.parameterize
to get rid of url-unsafe characters. This function unfortunately also
stripped off unicode characters.

Changes:
- parameterization extracted into a separate module Parameterizable...

Refs #3809 - Use parentheses in method definitions

Refs #3809 - Fix a few rubocop TODOs

fixes #4386 - gem friendly_id to simplify find by id, name, label, etc

fixes #7430 - Adds subnet mask validation

Fixes #7139: Subnet name is limited to 255 chars

Fixes #6444 - add support for virtual NICs

Extend additional interface details refs #2240

NIC facts parsing change and we create interfaces in Foreman according
to facts we recieve.

Subclasses does not define their own attributes and serialize them to
attrs hash. All BMC attributes are extracted to separate columns so it's...

fixes #6636, #6657, #6694 - add field length validations, extend audit field length

fixes #6529 allow to define IP suggestion per subnet

Fixes #6518 - look up the BMC proxy via any subnet proxies, if present

fixes #6216, #4416 - avoid foreign key errors when deleting some objects in use

fixes #812 - new permissions model, user group role and nest support, role filters for better granularity

• Daniel Lobato <elobatocs@gmail.com>
• Joseph Magen <jmagen@redhat.com>
• Tom McKay <thomasmckay@redhat.com>
• Greg Sutcliffe <gsutclif@redhat.com>...

fixes #3912 - add inheritance for locations / organizations

fixes #3975 - add audit to classes Domain, Subnet, SmartProxy, Role, Usergroup, AuthSource, Image, Bookmark that were not audited

fixes #3248 - missing N_() on validation messages

fixes #2741 - rails 3 syntax

fixes #3091 - strip leading and trailing whitespace before_save on names of all objects

fixes #3093 - invalid data for a subnet address or mask returns "is invalid and is invalid"

fixes #2985 - remove #as_json method from AR models since rabl views used for API

fixes #2285 - subnet validation - length of addresses, strip whitespace and fix common typos

fixes #2422 Rails 3.2: before_destroy / dependent => :destroy ordering

fixes #2421 added missing has_many :hostgroups and missing :dependent => destroy

Feature #2368 - i18n extracting strings

fixes #2254 - Add STI to hosts table

Signed-off-by: Joseph Mitchell Magen <jmagen@redhat.com>
Signed-off-by: Ohad Levy <ohadlevy@gmail.com>

Make sure we're not merging nil in to_json

Options argument might be nil. Therefore it fails when trying to call {}.merge(options) (for example when recording examples with apipie).

fixes #1814 - converts sp_* attributes into a BMC interface class

this patch also includes the following

• added a new interfaces table, and STI objects to represent a NIC, BMC, Managed
  and a bootable interface.
• refactored DHCP/DNS orchestation code, so they can work on the...

fixes #1992 sort does not fail if vlanid is null

Add organization and location to foreman.

This feature allows foreman to provide multi location, multi tenant and
multi organizations capablities.

the idea is that resources within foreman (e.g. hosts, subnets, users,
environments etc) can belong to one or more locations and organization,...

add subnets to safemode rendering

adds ec2 provisioning support fixes #1223

- added progress bar for instance creation
- minor fixes for certname based deployments
- added ssh provisioning support to orchestartion, which utilize finish
scripts by default
- added images support (part of the vm compute tab)...

code smell

fixes #1469 - vlan field missing in subnets

fixes #1281 - assingn more than one domains to a subnet

fixes #786 - Add the option to use existing DHCP reservations

note that this patch only ensures that the ip used is the same as the
existing dhcp record.
if there is a mistmatch in what foreman expects in the reservation vs.
actual state, #944 should kick in.

fixes #1432 - subnet gateway infos only saved when fill gateway and dns fields

the informations in the subnet form only saved if you fill the gateway and one dns fields
  the cause is the validation in models/subnets.rb

whyever the :allow_blank should work, but i need to add :allow_nil also to get this working...

fixes #1361 -- Add gateway and dns fields to Subnets

• Allow subnet values to be accessed in provisioning templates

fixes #1421 - expose subnet ranges for automatic IP address allocations

WIP rails3 migration

fixes #1209 - Show subnet name in the HOST editing screen

fixes #1201 - Import Subnets from DHCP server

fixes #1125 - tftp proxy might not always be initialized

fixes #1127 - add ip auto discovery when none is defined

fixes #1122 - extracted common REGEXPs

fixes #898 - remove old search leftovers across the app

Fixes #544 - Foreman connects using an ssl certificate

Signed-off-by: Paul Kelly <paul.ian.kelly@googlemail.com>

Fixes #65, Fixes #339 and Fixes #539

• Smart proxy CRUD within Foreman
• Subnet operations
  • CRUD
  • Finding the next free IP (via the dhcp proxy)
• Association of subnets, domains to proxies (dns, dhcp and tftp)

Fixes #366 - Redmine authorization port

This is a major feature which provides RBAC authorization within Foreman
a mental note to myself - never ever work on large commits

added the host_parameter_test, modified the Ensure_not_use_by issue in the subnet model and almost finished the subnet_test