Fixes #11188 - EnsureNotUsedBy checks for unscoped associations before destroying
Fixes #11407 - Uppercase logins from LDAP break external user group sync
On LDAP the login can contain uppercase chars, for instance, "FOO". Howeverwhen we log in Foreman for the first time and have that account auto-created,we can login using "foo". After that, our login will be saved as "foo" on...
Refs #3809 - Stabby lambda syntax for oneliners
I started by spotting log.rb which didn't have a lambda wrapping itsdefault scope, as needed by Rails 4. Since the style guide and mostRails 4 documents used the stabby lambda, I turned on the cop so that we...
Refs #3809 - Enable cop Style/IfUnlessModifier
fixes #5897 - when user doesn't have an email, email isn't required
Fixes #10928 - Default dashboard widgets for new users
Fixes #10740 - ignore auditing of all models in migrations
fixes #10829 - non-admin user cannot update admin password
fixes #9873 - generate unique alert mails for each user group member
To create distinct mails, new Mailer instances are required instead of usingthe same one - else, the last message changes the previous ones. The recipientlist is now determined in the ReportImporter, and the MailNotification helps...
fixes #10406 - add LDAP instrumentation and extra logging
Fixes #8106 - Dashboard rewrite to allow better customization
Fixes #9593 - replace .all.map(&:<attr>) with .pluck(:attr)
Refs #3809 - Remove classcheck cop
fixes #8049 - Add timezone to user
Fixes #7523 - Removed autocomplete search from id fields
Fixes #7233 - Drop Ruby 1.8.7 and revert Ruby 1.8.7 specifics
Fixes #7369 - External user groups update on login
fixes #7586, #7734, #7172 - user preferences for receiving mail notifications
Adds a framework for user-selectable mail notifications. The work isstill done in ActionMailer classes and launch by rake in cron, however awrapper called MailNotification is used to provide RBAC and make the...
Fixes #6710 - unicode characters in url parameters
Original methods to_param defined on resources called name.parameterizeto get rid of url-unsafe characters. This function unfortunately alsostripped off unicode characters.
Changes:- parameterization extracted into a separate module Parameterizable...
fixes #4439 - ensure user logins are handled case insensitively
Fixes #5139 - leftovers subscribe_to_all_hostgroups
Remove user_xxx unnecessary tables and notices
Update subhostgroups removed
Fixes for migration of foreign keys
Remove users from compute_resource fixture
Remove table notices after fk are removed for pg/mysql
Refs #3809 - Remove rubocop TODOs
Removed the following TODOs so that cops for these will run from now on:
Lint/AmbiguousOperator, DefEndAlignment, DeprecatedClassMethodsEnsureReturn, RequireParentheses, Void, BlockAlignment, EndAlignment,UselessAccessModifier,...
fixes #4386 - gem friendly_id to simplify find by id, name, label, etc
Fixes #7393 - searching users by role_id not supported
fixes #5811 - Validates emails to RFC 5322 specification
Fixes #7418 - fixed capitalization for some AR errors
Fixes #5929 - Taxonomy filter obey permissions
With this patch you can assign permissions like assign_organizations andassign_locations to particular user so that they can then assigntaxonomiesonly from set of taxonomies granted by their filters.
Global users would be still able to assign any taxonomy to a resource as...
fixes #7066 - add back $login interpolation for LDAP service account usernames
In cases where an LDAP connection is required outside of the context of userauthentication (e.g. validation of external user group name), an error isthrown. Users are recommended to use dedicated service accounts for this...
fixes #6964 - replace default scope that hides users with explicit scope
Fixes #6953 - Fixing N_() calls in the User model
fixes #6873 - ensure hidden 'owner' is populated on user role
Also re-order seeding such that the anonymous role is added to seeded users.
Fixes #813 - External usergroups can be linked to an LDAP auth source
fixes #6636, #6657, #6694 - add field length validations, extend audit field length
fixes #4641 - Ensure default role only after save/update. Change default role permissions
Fixes #6065 - Update TopbarSweeper to clear cache for other users than User.current
Fixes #6606 - Allow deletion of non-admin users if 1 admin
When deleting users, you get an error message if there's only one admin accounteven if the users aren't admins.
fixes #3272 - allow 'admin' account to be removed and replaced
fixes #6216, #4416 - avoid foreign key errors when deleting some objects in use
Fixes #6117 - clean usergroup cache
Dependent destroy was missing on through association from user side.
fixes #5869 - permit accents in user names on Ruby 1.8
fixes #5242 - Update external user attributes and group membership on every logon
fixes #3892 - process REMOTE_USER_GROUP_N and REMOTE_USER_GROUP_#, add user to groups based on external user groups.
fixes #5224 - Don't update a user with blank LDAP attribute values
fixes #5141 - User unable to access children taxonomies on switcher
fixes #3914 - set current taxonomies on login from user defaults
Fixes #4976 - ensure the process is really running inside a rake task
fixes #3827 - adds ldap avatar support
Fixes #4537 - user can set empty roles array via API
fixes #812 - new permissions model, user group role and nest support, role filters for better granularity
fixes #3912 - add inheritance for locations / organizations
fixes #4298 - ldap auth should accept parens in firstname or surname
fixes #3528 - Populate first name, last name, and email, if available.
fixes #3930 - refactoring of edit_self implementation.
fixes #3312 - support /users/extlogin as a login page based on REMOTE_USER
fixes #3249 - change regex syntax from start/end of line to start/end of string
fixes #2741 - rails 3 syntax
fixes #2945 - extend AR to add getter/setters *_name(s) for has_many/belongs_to associations
fixes #2741 - remove unnecessary require statements
fixes #2669 username first name and last name doesn't accept i18n characters
Fixes #2632 - extract strings from validation errors
fixes #2630 - restrict assignment of roles to those a user has (CVE-2013-2113)
fixes #2604 searching for hosts with digits can lead to unexpected results
Fixes #2519 - Protect locale changes from validation failure so thatpassword validation can be run
fixes #2281 - don't allow admin flag to be removed from admin account
fixes #2444 - locale selector in user account
fixes #2422 Rails 3.2: before_destroy / dependent => :destroy ordering
fixes #2421 added missing has_many :hostgroups and missing :dependent => destroy
fixes #2393 - Couple of models broken with audited 3.0.0
this is not a fix for the mass assignment problem, rather just to solve immedient packaing issue upstream.
a follow up on mass assignment should be done via another commit.
Feature #2368 - use N_ for model validators
As per https://github.com/grosser/fast_gettext/wiki/activerecord
Feature #2368 - i18n extracting strings
Enforce hostgroup/role uniqueness on User relation
upgrade foreman to rails 3.2.13
This commit updates from rails 3.0.x to 3.2.x, main changes include:
Users who uses foreman in production, make sure that you now compileyour assets, e.g...
fixes #2001 - Changing Loc or Org after compute resource selection give 500 error
fixes #2025 - show user login if name is blank
removed has_many_polymorphs and used has_many :source and :source_type
renamed to thread_session.rb
fixes #1978 - changing login maximum size to 100
In case of using a long login name (such as ovirt_username@domain), onthe fly login will fail. Increasing the maximum login size to 100.
ensures that admin user can't be duplicated when running within an org
Ensure existing org user search is unscoped
refs 611f5bff
Add organization and location to foreman.
This feature allows foreman to provide multi location, multi tenant andmulti organizations capablities.
the idea is that resources within foreman (e.g. hosts, subnets, users,environments etc) can belong to one or more locations and organization,...
refactor AuthSourceLdap Class
cleanup the classes, as it was aweful ruby.TODO: improve the logic between existing user and new users on the fly creaetion
Fixed validation error handling and auth durin admin user creation
Bug #1936 Allow user creation without email
auto create admin-user when missing in API requests
add getter for admin user User.admin which auto creates admin when missing
[SQL optimizations] - many small optimizations
fixes #1638 - remove whitespaces for user email instead of validation error
incorrect error message shown when trying to rename the admin account
Do not enable auditing while executing rake tasks / migrations
fixes #1613 - Email address format validation preventing admin user creation
audit as twitter and versions for template.
This also closes #1377 as it offer versions and diff view of the tempates.
it is not ideal, but it should handle the most common case for now,where we should open other feature requests to support all of the ideas in #1377
wip audits upgrade
fixes #1597 - Restrict compute resources access by user
And add some rights to give non admin users so they can perform some normal actions on the hosts they own.
unit/domain_parameter_test.rb self-broke... added a tiny fix.Removing compute_resources/vms nesting, it is such a nightmare for functional tests....
code smell
fixes #1324 - Separate permssions on hosts from permissions for objects within hosts.
This allows a user to be granted permission to edit the host (and so change the group or proxy) but not, for example, edit the parametersThis could probably be extended further if necessary.
fixes #1456 - renaming the admin account should not be allowed
fixes #1355 - Ability to Search Users by Role
Signed-off-by: Greg Sutcliffe <gsutcliffe@ibahn.com>
WIP rails3 migration
New artwork
fixes #1064 - last login info for a user without admin rights is not updated