Fixes #10607 - match bonds based on identifier only

(cherry picked from commit 7be20b248502eb8682008e1c6b03fef71da4f73d)

Fixes #10888 - skip attached_to updates if identifier was blank

(cherry picked from commit db6d6b8b7d0d2e90e27d4c23308e5db26abd3820)

fixes #10627 - apply host taxonomy scope to facts/report joins

Previous changes to perform a join onto hosts with authorisation result
in a query such as Report.joins(:hosts), which ignores any
default_scope on Host::Base. This commit explicitly passes taxonomy...

Fixes #10566 - allow identifier modifications that do not change interface type

(cherry picked from commit a6b8542a0e1a7eb0d71fdd1d328b224669e3010b)

fixes #10646 - disable NIC subnet taxonomy checks when feature's disabled

(cherry picked from commit d6a192531b7203b12f5e755a7b695435c423ece4)

fixes #8597 - escape slashes for ptable URL parameters

(cherry picked from commit 053c032dba5b52593c0235d96d74cdd1aae65721)

fixes #9873 - generate unique alert mails for each user group member

To create distinct mails, new Mailer instances are required instead of using
the same one - else, the last message changes the previous ones. The recipient
list is now determined in the ReportImporter, and the MailNotification helps...

Fixes #10535 - building a token instead of creating it until host is saved

(cherry picked from commit c2ff4bd6874155459a51af070abb381fd59be262)

fixes #10482 - get external user group members only once during refresh

(cherry picked from commit 0fd7412faaa76787bf15ed1901ffc9eb4d6353fa)

fixes #10509 - add toggle for LDAP usergroup updating

(cherry picked from commit 19bf6b096c03b999a02c82b61dfe0694cbb21a9a)

Conflicts:
app/models/auth_sources/auth_source_ldap.rb

fixes #10493 - disable usergroup sync on login when $login is used

(cherry picked from commit 7891164bffb6746b13dde15a2d38f3371d0abab7)

Conflicts:
app/models/auth_sources/auth_source_ldap.rb

Fixes #9170 - wrong nic order in libvirt domain

(cherry picked from commit 8aeac1b7b89fab21e0b92f54eb460fcc04415e07)

Fixes #9634 - creating a host with an interface and without os returns a validation message

(cherry picked from commit 93dbb7e77dc3502a5cfa6888a13212bed7e178f6)

Fixes #10379 - disables cloning if unattended mode is disabled

(cherry picked from commit 0f5c60f29626d02e91405db27bb057df34c7db39)

Fixes #9966 - More debug messages for matching nics from fog

(cherry picked from commit c796609085caeee03be4ec378b5311fd61ba6684)

Fixes #10212 - validate DNS name uniqueness of interfaces

(cherry picked from commit 60fdfb3851cad0ff347788c1f796d709693a8f27)

fixes #10403 - resync names of unmanaged hosts to their primary NIC

MoveHostNicsToInterfaces previously ignored unmanaged hosts, but they
need migrating too. Updated the existing migration to migrate both,
then for existing hosts, add a new migration to ensure all primary NIC...

Fixes #10307 - editing host with 'unattended: false' no longer results in error

(cherry picked from commit ae274f95193c3147ad563da075d0a36fb1bcff20)

fixes #10298 - handle destroyed but present interfaces

When deleting a host and DHCP orchestration is removing reservations for NICs,
it generates a dhcp_record that contains next-server data. Determining the
next-server IP causes the primary interface to be fetched for DNS resolution,...

Fixes #7458 - allow searching hosts by their ip and mac addresses

(cherry picked from commit e473d4d39f0d42747819d4ef098d9247690f540c)

fixes #10343 - only log cache deletion failures when saving settings

(cherry picked from commit 83bd400ce6d69c8f946ff5ed31012ab073fcf1b1)

Conflicts:
test/unit/setting_test.rb

Fixes #10305 - complete handling for cloudinit-like in vsphere feature

(cherry picked from commit 5d47a167cc2f2ea2bd9cbc88c30045f36949b636)

fixes #10030 - use override method to display templates in folders

(cherry picked from commit 0af12f79a6e6c3a3ecf72d39df89a2edd7e9b39b)

fixes #7743 - ensure name is unique in scope of major and minor

(cherry picked from commit 59b230959ab24b3573eb87616805bf3218a2cb13)

refs #5554 - revert string change, save unnecessary retranslation

(cherry picked from commit 4098e93bc45176ffd8f659d28d0db1f8cb1d7734)

fixes #9240 - in case of hash with indifferent access, serialize as hash

(cherry picked from commit 3059cea1c207718217f07b9cdc706bc516f5db1b)

Fixes #5554 - fixed hostgroup and fqdn validations in multiple matchers

(cherry picked from commit eb414b8bbdc7897f396d184996fac402b3277cef)

fixes #8817 - look up reports with all joins from host scoped_search

This changes the optimisation in d50c799 which caused errors for users with
host filters referencing tables other than hosts.

When retrieving all reports joined with authorised hosts, the nested joins need...

Fixes #9391 - Added validation code to NIC, so it validates that host's location/org is compatible with the one set on NIC's subnet

(cherry picked from commit 8f695d94a2f32fea3363cc017fc59baf6ca15b17)

fixes #9617 - rescue from empty vmware clusters

(cherry picked from commit d76ca3043ca1bac1229667e342da149e3cd6f304)

Fixes #10186 - find host NICs on vsphere using Network Distributed PortGroup

(cherry picked from commit 4e21396fdf68fa21f3beac1cd460dcfe5c700c38)

fixes #10168 - delegate fqdn/shortname to primary interface

(cherry picked from commit 4d5b979541902c2163d98ca8fd53d230445b60ac)

Fixes #10111 - Use a dummy primary interface for unmanaged hosts

Unmanaged hosts require a host interface due to delegation of networking
attributes, and some others like 'name'. Since unmanaged hosts do not
necessarily have an interface associated (unless created through puppet...

fixes #10020 - add next-server/filename attrs to provision NIC DHCP record

A host's DHCP record used to be constructed with PXE attributes in
Orchestration::DHCP, but moved to Nic::Managed during 43c4bd7. Nic::Managed
didn't add PXE attributes, so this commit adds these when provision? is set....

Fixes #10093 - VMware#create_vm calls clone_vm

Apply '.with_indifferent_access' to the args passed in to create_vm,
ensuring symbol test for args[:image_id] succeeds when args["image_id"]
is present.

(cherry picked from commit 140cfe262eac838e76eb27517bd0271beab9be15)

fixes #10087 - Pass nic_type to vm_clone

(cherry picked from commit f25e9797d6ae1e2dfebf268934ffd7d17536efbf)

Fixes #10025 - move generic taxonomies code to base class

(cherry picked from commit bf75590c49c05dd780df388908598c85fc8f53bd)

refs #8817 - Revert "fixes #5841 - use inner query when retrieving reports for subset of authorised hosts"

This reverts commit ecdb85a84915954f312889ba51a9b35de86cd38c.

Fixes #9947 - restrict user taxonomies if none is set

(cherry picked from commit abe910f2a46f4ecc1f349263d0b4751ed46ff200)

Fixes #7615 - filter ignore current context

(cherry picked from commit 76fca93b0093e9b4174d1a888ffca9f3fcb886c9)

refs #4521 - Openstack Compute Resource: Boot from Volume on new Host

(cherry picked from commit 3f56eab265fdec913f988a119d78771d345c5428)

Fixes #9362 - Corrected CoreOS mediapath

(cherry picked from commit 9f858eb43200809f931321821880f1ae9ca9db54)

fixes #9778 - return r/w host when finding and associating to CRs

(cherry picked from commit cd4c4ad907fdadae66576f64831204711748bef3)

Fixes #9926 - do not always set LDAP encryption method

(cherry picked from commit 5d5e0bb601ad75a514168a263a6a360c496cb2af)

Fixes #8890 - Allow selection of plaintext "encryption" method for root password

(cherry picked from commit 331ff165939399787022e77ad17778e2ac39c148)

Fixes #9618 - make identifier uniq per host

(cherry picked from commit f2d5f95539b5070f5c7aba37196c45346140357d)

fixes #6568 - showing ovirt template version if applicable

(cherry picked from commit a647442376aceae2e539791790eb8f308b56cd3a)

Fixes #9885 - pass verify_mode to net/ldap

(cherry picked from commit fc3faf6f4e8c1f0efd62e8c58687b3d30c69b67e)

Fixes #8601 - Cloudinit userdata in VMware

(cherry picked from commit 5b1f7529284e9e62d9f8f08977b543d4a7b93f21)

fixes #7407 - puppet class parameters should be cloned in #clone

(cherry picked from commit 7691ab4a56a49118f6cf97ca7f6de1c932b99e2a)

Fixes #9869 - propagate LDAP errors

(cherry picked from commit e1e7d0686b7ab3c329e2b9884b7731a3005c9276)

fixes #9775 - always load Encryptable when key's missing, log runtime warning

a59972c3 causes Encryptable to be loaded before the encryption_key.rb
initialiser and the majority of the class was skipped as the key was undefined.

Now Encryptable always loads, but logs at runtime if the key is unavailable,...

Fixes #9434 - managed alias accepts only static boot mode subnet

(cherry picked from commit a45253c2b7c747b15506dddc4efa86396c6ef53f)

fixes #9795 - check if mail is enabled before sending a notification

(cherry picked from commit 7ca39b3442be76da89c2c52d8da0c2d6afb74af1)

Fixes #8779 - add vlanid to subnet ENC

(cherry picked from commit a899d97175c683bb648e3cbd34d0aebcae1252cf)

Fixes #6454 - Display error message when user_data is needed but not set

(cherry picked from commit b99708ac7a1bb0e139505c2549c0f36fa5a65f83)

fixes #4424 - overriden attributes get overridden in the UI

(cherry picked from commit 0575b5b0a07c59c443bf2be663cb67d6a5e40f19)

Fixes #9657 - merge NICs from compute profile in host create API

- updated api docs for hosts and interfaces
- host create/update api actions now merge interfaces from compute
profiles
- NIC type mapping extracted into a separate class
- return full host detail after host update...

fixes #8358 - validate domain on host update

(cherry picked from commit cbe1391f48f37d4bf9a53091c668b6a91bc6ef83)

Fixes #9480 - multiple NICs integration with compute profiles

From users point of view:
- interfaces setup in compute profiles is back
- interface related compute attrs get merged into host NICs upon compute
profile selection
- NIC overview table displays details in the column "Type"...

Fixes #8316: Removing a host can create a huge transaction

(cherry picked from commit 3e7507198f25b41b90a55115671fe0edd495f531)

Fixes #9615 - Adds inheriting_mac method

Using this method we can find out the MAC of interface to which this
interface is attached to. This can be used in provisioning template when
we check for real interface name.

(cherry picked from commit 5ad3c4f34b50fb1ac6d9f26e71e183813ab1c96f)

fixes #8878 - ensure domain fact is downcased prior to import

(cherry picked from commit 25a647eb04ac2d31af99c85e447d58d1de4185e6)

Fixes #9339 - Changed the OS sorting to title

Title uses the full string, not only the name part.

(cherry picked from commit 61b5da1bb089a313375ef232e2643b0cd422bf92)

Fixes #9590 - make info test less fragile

(cherry picked from commit e24c3fbbe5d089f76b89f909b65b2bd2205a5035)

Fixes #9495 - Require identifier for managed bonds

(cherry picked from commit e329155b185e3be5863bfd79582b61a6ecc9ae9a)

Fixes #9497 - Require MAC for managed BMC

(cherry picked from commit 6a2fce1fa6a80865bb8292e76a8bd285e714a5c8)

Fixes #9147 - move managed checks to the start of the DHCP/DNS/TFTP orchestration checks

(cherry picked from commit 5440d482b0087fe29b3fb4567e0ca73f2d3af221)

fixes #7764 - add quirks mode to JSON.dump

(cherry picked from commit 8dcb01a429e88a12edd605672e6f4340de7ca977)

fixes #8331 - provide some tools for filtering mail

(cherry picked from commit a08e66ff1192e00d6dd8eafccd5bf5cd0e4183f9)

Fixes #9500 - matching uses the whole domain name

(cherry picked from commit ede6d4ea8b266e3a90fc6c639929be2b55be225c)

Fixes #9452 - correct capitalization of VMware

Fixes #5998 - add taxonomy tabs to config_template#edit

Fixes #9429 - identifier is required for Alias and VLAN

fixes #8581 - [vmware] use cluster full path to create vm

Refs #3809 - Remove classcheck cop

Refs #3809 - Remove cop IndentationConsistency

Refs #3809 - Remove cops for empty lines

fixes #8953 - update IPA userclass param on realm update

fixes #9369 - tftp should send host, not self to get the boot files uri

fixes #9362 - Add mediapath support to CoreOS

fixes #9274 - hostgroup#clone clones config groups

fixes #9249 - associated_host fixed for all compute resources

Fixes #9186 - build interface if needed during facts import

fixes #9124 - fixes detection of hashed root passwords

A root password that started with "$" would not be hashed, and therefore
would end up being stored in clear text and inserted in clear text to the
/etc/shadow file, which just won't work. This adds a bit more to the match...

Fixes #9104 - allow disabling of interface updates

fixes #8565 - only get unique, unused message/source IDs to speed up expiry

Fixes #6884 - Installation media without $minor generate broken $version

$version is generated with the major version and a dot, producing paths
like foo.bar/x64/7. which don't exist. For CentOS at least we want to generate
a path without the dot. The default values for these media have been changed too.

Fixes #9160 - use provision interface for image based provisioning

Refs #3809 - Enable cop StringConversionInInterpolation

Fixes #8052 - allows erb in array and hash params

Fixes #7456 - Extract primary interface from host

• Tomas Strachota (tstrachota) <tstrachota@redhat.com>
• Marek Hulán (ares) <mhulan@redhat.com>
• Gregory Sutcliffe (GregSutcliffe) <gsutclif@redhat.com>

All host must have at least one primary interface and one provision (can...

Fixes #9097 - Fix typo in value_to_sql method

fixes #8498 - Allows root password to be set in finish scripts

Refs #9049 - fix log message formatting

Missing "%s" in the commit that was supposed to fix #9049 caused the
exception message not to be printed into the log.

Fixes #9099 - Upgrade rubocop to 0.28.0

Fixes #2948 - added sp_* host attributes to safe mode

Refs #2948 - Add sp_ host attributes to jail test

Fixes #9059 - adds puppetssldir setting

Fixes #9044 - fixes invalid mac in tests

Also do not reset invalid mac address to nil so we can propagate proper
validation error.

Fixes #9049 - Log exceptions when triggering a Puppet run

If an exception occurs during triggering a Puppet run from the UI,
user will be notified of the error in a flash message. If the
exception occurs when running the action non-interactively (e.g. from...