Fixes #19873 - Fix Style/MultilineIfModifier cop (#5705)

• Refs #20891 - fix for new rubocop rules

• Fixes #19873 - Fix Style/MultilineIfModifier cop

Fixes #19789 - fix Layout/SpaceAroundOperators cop

Rename method that does not cache

Fixes #23608 - Only calculate lookup values once

Fixes #19787 - Fix Layout/SpaceAfterComma cop

Fixes #20931 - unify parameters and templates renderer (#4835)

• Fixes #20931 - unify parameters and templates renderer

Before this patch, we used separate renderer for the parameters. This
caused issues when introducing more dsl methods for the templates that...

Fixes #21946 - Correctly match fact names in classification

Matches generator throws an exception when calling #fact_name

Fixes #15711 - Redesigned host info to providers.

Now you can add your own info by registering a
host method that will return info hash.

Fixes #19700 - update rubocop rules

The following changes have been made:

- Performance/RedundantMerge:
changes lines such as:
```not_found_message.merge! :message => options```
to:
```not_found_message[:message] = options```

- converts str.match() to str =~ ()...

Fixes #17874 - Extract contains_erb? from lookup key

Fixes #15846 - Renamed use_puppet_default to omit in LookupValue

Refs #12193 - Remove remaining cached counters

Refs #3809 - Turning on the AndOr cop

Fixes #5785 - override class parameter by subnet name

Refs #3809 - Turning on some rubocop cops

Fixes #12911 - Turning on 0.35.1 cops

Fixes #12249 - Use puppet default on specific matchers does not send default value to puppet

fixes #11415 - using the correct method for classification caster

fixes #3145 - host with a lot of parameters quicker

fixes #10832 - separating lookup keys into puppet and variable

Fixes #10731 - Allow matches to merge with default values

fixes #10232 - moving validations and casting out of lookup key and value

Refs #3809 - Enable cop Style/IfUnlessModifier

Fixes #10409 - Rails 4 compatible changes with Rails 3

Fixes #8333 - correct matcher values with multi-key matchers

Fixes #9787 - correctly typecast default values

JSON and YAML default values were double typecasted, once by active
record and then by value_of_key method.

Fixes #9673 - treat YAML and JSON lookup keys as strings

Refs #3809 - Remove cops for empty lines

Fixes #8052 - allows erb in array and hash params

Fixes #8551 - use most specific matcher for inherited hostgroups

Host recieves correct smart_class_parameter value when multiple overrides for
inherited host groups exist for parameter.

Fixes #3260- Allows puppet to manage value of smart class parameter that can be overrided

Fixes #3309 - Support deep merging of hash and array structures in smart class parameters

Refs #3809 - Use parentheses in method definitions

Refs #3809 - Fix a few rubocop TODOs

fixes #7163 - on host's edit page, show the source for the value of puppet class parameters.

fixes #5246 - remove second host/class lookup impl so config groups are included in ENC output

fixes #5105 - remove Setting['remove_classes_not_in_environment']

fixes #2260 Allow ERB in ENC global / class parameters

Adds code to parse the global & class parameters, and adds a setting (default true)
to disable this if needed. Also has some tests.

fixes #2411 - move files in /models to /concerns, /services, /mailers, /observers