Fixes #19873 - Fix Style/MultilineIfModifier cop (#5705)

• Refs #20891 - fix for new rubocop rules

• Fixes #19873 - Fix Style/MultilineIfModifier cop

Fixes #19789 - fix Layout/SpaceAroundOperators cop

Fixes #19781 - Fix Layout/LeadingCommentSpace cop

Fixes #19787 - Fix Layout/SpaceAfterComma cop

Fixes #22809 - Turn VM attributes to hash (#5403)

Fixes #23081 - Fix Style/SafeNavigation cop

Fixes #19796 - Fix Layout/SpaceInsidePercentLiteralDelimiters cop

Refs #22285 - Allow unwrapped params on API

Fixes #18675 - telemetry foreman API

Fixes #19889 - Fix Style/PerlBackrefs cop

Fixes #19907 - Configure Style/TernaryParentheses cop

Fixes #19895 - Fix Style/RedundantReturn cop

Fixes #21760 - Fix tests on Rails 5.1

Fixes #21176 - don't modify strong param filter rules

Fixes #19039 - Lock plugin roles

Fixes #17811 - Improve error message LDAP fail

Fixes #15711 - Redesigned host info to providers.

Now you can add your own info by registering a
host method that will return info hash.

Fixes #19700 - update rubocop rules

The following changes have been made:

- Performance/RedundantMerge:
changes lines such as:
```not_found_message.merge! :message => options```
to:
```not_found_message[:message] = options```

- converts str.match() to str =~ ()...

fixes #19317, #10927 - move registries to autoload_once path

Partially reverts 70ce8fe to reinstate autoload_once_paths as the
preferred way to load registry-type objects with class variables
containing data set up during app initialisation (e.g. plugin
registrations, menu items.)...

fixes #19192 - adds mark all as read notification action

This implements missing feature from patternfly ( see http://www.patternfly.org/pattern-library/communication/notification-drawer/#/code/angular)

Refs #18001 - Avoid role extending from rake tasks permission

Fixes #18001 - Add plugin permissions to core's roles

Fixes #18977 - Do not raise on creating a role in plugin when in Rake

fixes #12419 - template preview host has typeahead

fixes #18064 - import host from compute resource

fixes #18476 - users have ssh keys

Fixes #18718 - Empty boolean matcher should not turn into false

Fixes #18317 - Clone user role via API

Fixes #7495 - Create/delete autosign entries via API

fixes #18511 - plugin authors shown nicely

Fixes #18440 - removes dead code and obsolete permission

fixes #13618 - cache expensive vmware api calls

fixes #18233, #18235 - isolate pagelets state between tests

Moves pagelets state into instances of Pagelets::Manager with clearer
dup semantics, and allows the instance to be backed up and restored
around tests using the PageletsIsolation test case mixin.

fixes #18214 - accept `params` as AC::Parameters or Hash

In Rails 5, ActionController::Parameters no longer inherits from Hash
and so type checks for params.is_a?(Hash) now return false and should
accept either. (Rails commit 14a3bd5.)

fixes #17545 - adds UI notification support

- Initial data model for notification support, based on manageiq design.
- addes notification JSON endpoints.

Fixes #16740 - Access host params through macro

Fixes #17874 - Extract contains_erb? from lookup key

Fixes #17015 - Adds Key pairs controller

fixes #16459 - remove 1.15 deprecations

Fixes #16739 - unify parameters permissions

Fixes #17403 - enable exporting of templates

Fixes #14688 - Power status visible on hosts index page

Fixes #17309 - Made facets resilient to class reloading

Now the configuration is stored in plugin declaration.
If you are using `Facets.register` directly, please make sure
you are re-registering it after reload occurs.

Fixes #16646 - Add ability to plugins to modify index scope

fixes #16821 - store plugin permissions in AccessControl in tests

When initialising a new test database, the "permission" directive in a
plugin registration would skip the Foreman::AccessControl mapping so
later tests using the access control lists would fail (e.g....

Fixes #6492 - ipmi_boot permission renamed to ipmi_boot_hosts

Authorizer expects permission names to follow a convention
'action'_'controller'. However this permission was not following it, and
this prevented the permission from being applied properly.

Before this fix, only admins could call ipmi_boot. I've also added a...

fixes #16725 - add plugin extension point for smart proxies

Fixes #16797 - Log pending migrations

It's possible that permissions will not load due to pending migrations.
are pending. This would help us figure out if this problem occurs when
running plugin tests in jenkins.

Fixes #15926 - [API] Add method to get ENC values of a host

Fixes #14375 - Add search to bookmarks controller

Fixes #7806 - allow taxonomy association on role level

Fixes #16044 - Load dashboard widgets via ajax

This speeds up dasboard loading as widgets are loaded in the background
and do not block rendering, as well as allow the dashboard to load
correctly even if some of the widgets are broken.

refs #13768 - add random_name call to create_hosts permission

Fixes #15924 - Implement server groups and scheduler hints

Fixes #13768 - random and MAC-based name generator

fixes #15919 - statistics page is loaded via AJAX

Also:
- refactor how statistics data is being called, now it should be trivial
to add additional charts or consume other data from it. It should make
it much easier to reuse statistics charts in other places...

Fixes #14301 - Grant access to help pages for view permissions

fixes #3917 - replace protected_attrs with strong parameters

Filtering of attributes has moved from the protected_attributes gem to
strong parameters in controller concerns, to be in line with current
Rails recommendations.

Concerns are shared between UI and both API controllers and list the...

Refs #3809 - Using defaults for AndOr cop

Fixes #15464 - support partials in pagelet keys

Pagelets will be keyed as "#{controller}/#{partial_name}". This
removes a necessity to register a pagelet multiple times if a
partial is reused for different actions.

Refs #3809 - Turning on the AndOr cop

fixes #15622 - add about link for non-admin user

Fixes #13164 - Add view_params permission

A new view_params permission was added for parameters inheriting from
Parameter object. The only exception is global parameters, which are
already handled by filter for CommonParameter resource.

This new permissions is also automatically added to viewer and site...

fixes #9110 - add freeip route to API

Fixes #14546 - ability to restrict *_external_variables
Fixes #14535 - corrects permissions for smart class parameters

Fixes #14969 - correctly reload custom statuses

Refs #3809 - Turning on some rubocop cops

Fixes #14957 - Use a temporary status file to store exit status

fixes #14742 - retrieve template kind labels from plugin regs

Ensures plugin kinds registered in class variables aren't lost when the
TemplateKind class is reloaded.

Fixes #14395 - Label for provision template capitalized in os details page

s

Fixes #14588 - introduce plugin API for extending template helpers

Fixes #14476 - Correctly handle casting of invalid real param values

fixes #12746 - list compute resources from plugin definitions

Load the full list of known CRs from plugins on the fly, instead of
modifying the class-level list of supported plugins. Since plugin
definitions don't get reloaded, this allows the ComputeResource class to...

fixes #14131 Changed bash to sh

Fixes #14129 - remove duplicate declaration of KEY_DELM

Fixes #13417: Provide facet registration through plugin API

fixes #13647 - change puppet ca proxy for several hosts at once

fixes #12436 - as a user I want to deploy vSphere vms on a storage pool

fixes #13494 - change puppet proxy for several hosts at once

This commit adds the possibility to select multiple
hosts and change the puppet proxy for them.

Refs #12911 - Fixing colon method calls

Fixes #12718 - smart proxy log table

This patch adds a table with logs fetched from Smart Proxy /logs new API. It
returns latest N log entries from a simple memory buffer. The table supports
filtering by level, custom filtering and it introduces several overview...

Fixes 13401 - ssh_provision: safe stderr as well

The log file currently only gets stdout which leaves only guessing when
looking for provision errors.

fixes #13236 - apply power operations to several hosts at once

This commit adds the ability to select multiple hosts and apply power operations
(reboot, shutdown, boot) to them.

fixes #13298 - ssh_provision: Don't use /tmp

On some systems (e.g. SLES12) /tmp is mounted noexec by default so not
usable to run the provision script. The home directory of the
connectiong user should be writeable by itself though so just use this
instead.

Fixes #12720 - Add tabs for puppet on proxy show page

This patch adds two tabs to the proxy show page related to puppet
1. Puppet - this tab is for proxies managing a puppet master. This tab
displays information about the puppet master, such as number of classes...

Fixes #13079 - Conditionally hide the pagelets

Fixes #13160 - pagelet tab names gets translated

fixes #13131 - plugin tests to skip is back

Fixes #11618 - Replace validation tests by shoulda-matchers

A good chunk of our unit tests are testing whether a validation is
working or not by testing it actively. For the validations we've
added ourselves I would say it's fine. However for validations that...

Fixes #12716 - Extensible pages for smart proxy with mount points

fixes #13039 - remove TemplateKind DB calls from UnattendedCtlr

UnattendedController created actions/methods during initialisation per
known TemplateKind, relying on the DB being populated. This caused
ordering issues when a plugin loaded the controller in a test...

Fixes #12957 - removing current_parameters from hostgroup

Fixes #12754 - adds permission name to 403 page

fixes #12714 - Show proxy status in index, and create a show page for proxy

Fixes #7230, #12021 - Upgrade to Rails 4.1.5

This commits upgrades Rails to Rails 4.1.5. See a description of the
changes included here, and go to the pull request in GitHub to see more
detailed explanations:

• Update gems to a Rails 4 compatible version, including dependencies...

fixes #11862 - validating that casted hash is valid

Catch parse errors correctly under Ruby 1.9.3, and ensure the uncasted
value is displayed back in the UI if it fails to parse.

fixes #1584 - bulk owner change

fixes #12624 - add plugin interface to add provision methods

fixes #12632 - remove hardcoded SSH compression algorithm

net-ssh behaviour changed in 2.10 from treating a specified algorithm
as a preference (and falling back to one it knew) to treating it as a
whitelist of algorithms. OpenSSH servers need the algorithm...

Fixes #12506 - Show smart proxies version in about page