Fixes #19873 - Fix Style/MultilineIfModifier cop (#5705)

• Refs #20891 - fix for new rubocop rules

• Fixes #19873 - Fix Style/MultilineIfModifier cop

Fixes #19789 - fix Layout/SpaceAroundOperators cop

Fixes #23775 - exposed random name generator

Rename method that does not cache

Fixes #23608 - Only calculate lookup values once

Fixes #23487 - support namespaced controllers

fixes #23621 - passwords can be md5 hashed

Fixes #19781 - Fix Layout/LeadingCommentSpace cop

fixes #21657 - remove facets when host is removed

Fixes #15411 - Move smart_proxy_ids_for to Host

Fixes #22855 - Add full breadcrumbs functionality

Fixes #19787 - Fix Layout/SpaceAfterComma cop

Fixes #22809 - Turn VM attributes to hash (#5403)

Fixes #19848 - Set Style/Alias cop to prefer_alias_method

Fixes #23113 - Allow disabling of out of sync status

Fixes #23081 - Fix Style/SafeNavigation cop

Fixes #19894 - Fix Style/RedundantParentheses cop

Fixes #19796 - Fix Layout/SpaceInsidePercentLiteralDelimiters cop

Fixes #19839 - Fix Rails/Present cop

Fixes #22331 - Fix Rails/Presence cop

Fixes #23123 - Fix Rails/ActiveRecordAliases cop

Fixes #23077 - Fix Style/TrailingCommaInArrayLiteral cop

Refs #22285 - Allow unwrapped params on API

Fixes #19857 - Fix Style/EachWithObject cop

Refs #22310 - Fix minor rubocop issue

Fixes #22796 - fact importing telemetry

Fixes #21120 - orchestration tasks are added only once (#5079)

Fixes #22798 - VMware: Fix exception listing VMs

If a VM is in the root of the datacenter its parent is the vmFolder.
This folder was being skipped by the PropertyFilterSpec causing an
undefined method error '[]' for nil:NilClass when accessing the
vm['parent'] key.

Fixes #22779 - Calculate out of sync host via origin interval (#5221)

Fixes #18675 - telemetry foreman API

Fixes #19244 - added clean interfaces rake task

Fixes #22310 - Implement report scanner to identify origin (#5186)

Fixes #22379 - Remove pagination from csv export (#5204)

fixes #22515 - use hostgroup_title for search in chart links (#5238)

Fixes #22489 - move the notification base class

Fixes #19889 - Fix Style/PerlBackrefs cop

fixes #5125 - list available vmware images

Fixes #21317 - graceful handling of VM association error

Instead of immediate failure, just log the issue and proceed with the
import.

Fixes #17521 - Use short name for hosts

This commit enforces the policy of using short name for hosts
while preserving the fqdn for interface values provided the user has
enabled 'append_domain_name_for_hosts' Setting.

Fixes #22190 - Pass empty hash when options is nil (#5164)

Fixes #19907 - Configure Style/TernaryParentheses cop

Fixes #19871 - Fix Style/MethodDefParentheses cop

Fixes #19877 - Fix Style/NegatedIf cop

Fixes #19895 - Fix Style/RedundantReturn cop

fixes #22258 - vmware: speed up vm listing

Fixes #20931 - unify parameters and templates renderer (#4835)

• Fixes #20931 - unify parameters and templates renderer

Before this patch, we used separate renderer for the parameters. This
caused issues when introducing more dsl methods for the templates that...

Fixes #20929 - Added fact name filtering on import

Added a setting that will filter out fact names, so they won't be
recorded into `fact_names` and `fact_values` tables at all.

Fixes #19769 - Fix Layout/CommentIndentation cop

Fixes #19778 - Fix Layout/IndentAssignment cop

Fixes #19780 - fix Layout/IndentationWidth cop

Fixes #19820, #19822, #19824 - Fix some performance cops

Fixes #21875 - added support for sha512 grub passwords

All new hosts provisioned using default and rhel
kickstarts will use sha512 grub passwords from
now on.

Fixes #21760 - Fix tests on Rails 5.1

Fixes #19772, #19773, #19774 - Fix some empty line cops

fixes #21823 - adds foreman user agent to RSS loading (#5039)

Fixes #21946 - Correctly match fact names in classification

Matches generator throws an exception when calling #fact_name

Fixes #21776 - Improved fact importing to deal with names

Now the list of fact names will be calculated beforehand and saved
to the database. It will also consider that the name could be added
from other thread.

Fixes #21826 - rss notifications are duplicated (#5042)

From my understanding "item.summary" isn't passed to the created
Notification which made it weird why it is used when checking if
it exists.

Signed-off-by: Boaz Shuster <ripcurld.github@gmail.com>

Fixes #14583 - reworded orphan taxonomy validation error

Fixes #18292 - Make notifications from an RSS feed (#4240)

This adds a task to connect to an RSS feed, by default the one from our
community blog. The idea is to make this run every night with 'cron' on
every Foreman installation to keep people updated about changes, and...

Fixes #21599 - explicit transaction for import dropped

Fixes #21584 - set taxonomies for chart requests

Fixes #21503 - Import puppet classes when organzations changed

Fixes #21026 - Clear cached notifications properly

Using `delete_all` for has_many does not trigger callbacks
on the associated objects, `dependent: :destroy` does.

Clearing the cache needs to happen anytime a notification
gets created, modified and destroyed, `after_commit`...

fixes #21394 - user login with access token api

Fixes #21253 - fix latest events widget

Fixes #21232 - verify IP sans when authenticating a SP

Fixes #21176 - don't modify strong param filter rules

Fixes #15409 - Separated puppet facts from core

Fixes #21104 - Recognize br-ex etc as bridge interfaces

Extends the bridge regex pattern to allow bridges named after purpose
like br-ex, br-tun as documented in openstack dvr scenario.

Fixes #20955 - Remove conditions to {destroy, delete}_all calls

Fixes #20950 - Use 'distinct' in AR finders

Fixes #20956 - Don't pass class constants to AR conditions

fixes #20653 - ui notifications for hosts with usergroup owner

Refs #19050 - Update Rails 5.0 to 5.0.6

Fixes #19039 - Lock plugin roles

Fixes #20622 - puppet import does not refresh all statuses

Fixes #20475 - Random DB IPAM with MAC preservation

Fixes #17811 - Improve error message LDAP fail

Fixes #20248, #20327 - Respect context in CSV export

Since CSV export is done using an enumerator which is executed by a
different thread to the one that creates it, we need to manually pass in
the context (user, location, organization) to the enumerator.

Fixes #20418 - Add taxonomies to newly imported puppet env

fixes #16592 - keep consistent for headline capitalization

Based on PatternFly Outline Headline Style, Suggested to
keep consistent in headline capitaliztion.

Fixes #20378 - Puppet 5 environment detection

Fixes #16884 - enforce granular filters even during save

Fixes #19828 - Fix Rails/Blank cop

I disabled the default UnlessPresent value since sometimes it's clearer
to use `unless attribute.present?` instead of `if attribute.blank?`.

Fixes #19266 - fix_db_cache crashes Rails initialization

The Filters cache that CacheManager recreates when
fix_db_cache is true, fails when the roles associated with said
filters are locked. To generate the cache, we call `.save` on the filter
object, which is not allowed by Role....

Fixes #19823 - Fix Performance/StartWith cop

Fixes #15711 - Redesigned host info to providers.

Now you can add your own info by registering a
host method that will return info hash.

Refs #19588 - Allow passing header to csv responder

Fixes #19952 - Allow view_audit_logs to work

Every time the /audits page is visited by a non-admin user, it checks
whether the permission 'view_audit_logs' is for the Audit class. In
previous versions of 'audited', this was
Audited::Adapters::ActiveRecord::Audit, but right now it's simply...

Fixes #19588 - Allow setting custom headers in CSV export

Fixes #19585 - Allow csv export of nested attributes

This is required for example to export host facet attributes.

Fixes #19700 - update rubocop rules

The following changes have been made:

- Performance/RedundantMerge:
changes lines such as:
```not_found_message.merge! :message => options```
to:
```not_found_message[:message] = options```

- converts str.match() to str =~ ()...

Fixes #16159 - Rename mail alerts to not be Puppet specific

Right now, under 'my account', users get emails with alerts about the
status of their hosts regarding configuration management (e.g: if there
was an error, get an alert, or get a weekly summary of all hosts...

Fixes #19034 - add tasks for clearing expired notifications

fixes #19528 - rewrite FiltersHelperOverrides to support autoload

Replaces class-level filter search overrides storage with a query
against Foreman::Plugin, allowing the class to be reloaded and tested
safely. Removes another 'registry' class.

Fixes #19534 - improved orchestration task logging

fixes #19464 - rewrite Dashboard::Manager to support autoloading

Replaces class-level widget storage with a static list of built-in
widgets, then appends the registered plugin widgets to get the full
default list of widgets. As a result, the class can safely be reloaded...

fixes #19317, #10927 - move registries to autoload_once path

Partially reverts 70ce8fe to reinstate autoload_once_paths as the
preferred way to load registry-type objects with class variables
containing data set up during app initialisation (e.g. plugin
registrations, menu items.)...

fixes #19192 - adds mark all as read notification action

This implements missing feature from patternfly ( see http://www.patternfly.org/pattern-library/communication/notification-drawer/#/code/angular)